javascriptdata / danfojs-doc Goto Github PK

Looking at the source code it looks like there is no danfo.dataframe.columns.md file.

The source links for the function source code are out of date and broken.

Eg the source link for https://github.com/javascriptdata/danfojs-doc/blob/master/api-reference/series/series.dropna.md links to https://github.com/opensource9ja/danfojs/blob/master/danfojs/src/core/series.js#L93 which results in a 404 if you click it.

I have fixed these on a commit in a fork off of masterand would be happy to submit a PR if you're interested.

I just wasn't sure if these docs are autogenerated somehow. If you would accept a PR, should I use a hash or tag so that the docs point to a specific commit and don't get out of date or should I use master and then at least the source will point to the latest version?

Thanks,

Colin

The documentation at https://danfo.jsdata.org is a fantastic help for beginners, if only every JS library would go in to such depth. Still it seems some links still point to https://jsdata.gitbook.io/danfojs which does not/no longer exists.

Take the "Accessor" link on https://danfo.jsdata.org/getting-started#time-series page for example, or the "merge" link right above the Grouping section on https://danfo.jsdata.org/getting-started#grouping.

References javascriptdata/danfojs#102 which I opened on the wrong repository.

All these methods under groupby are documented lowercased instead of cumSum: https://danfo.jsdata.org/api-reference/groupby/groupby.cumsum

corr() function doesn't work

Hello,

The link to the 'Config' info is broken on this page.

https://danfo.jsdata.org/api-reference/general-functions#utility-and-configurations

Here's the tag
<a href="https://github.com/javascriptdata/danfojs-doc/blob/master/api-reference/general-functions/broken-reference/README.md" data-rnwi-5xr8s6-dse9kg-2fw26j-aznvpw-focus-visible="true" data-rnwi-handle="link" class="css-175oi2r r-1i6wzkk r-lrvibr r-1loqt21 r-1otgn73 r-1471scf" style="transition-duration: 0.25s;"><span data-key="be3e6c57562246c4b6311b58d42cec17" data-rnwilink--avujh5-="true" data-rnwilink--ah72ng-1ddef8g-hover="true" data-rnwi-handle="nearest" class="r-crgep1"><span data-key="6eaa647a86bb4aadb0e997d9190019b4"><span data-offset-key="6eaa647a86bb4aadb0e997d9190019b4:0">Config</span></span></span></a>

Here's the bad link.

https://github.com/javascriptdata/danfojs-doc/blob/master/api-reference/general-functions/broken-reference/README.md