jasbrake / acpinger Goto Github PK

The Issue

Occasionally a player in the extended pong will have a ping of 9999 and the name will be empty. I think this happens when a player times out, given that 9999 is the max ping allowed by the server.

Resolution

I think we can safely skip adding any player with an empty name and a ping of 9999 to the player slice given that they appear to be disconnecting anyway.

Currently the library does not parse negative numbers from server responses.

Attempting to parse a byte array that is too short results in a unhandled "index out of range" error. This can be prevented by checking if more bytes exist before trying to read and returning an error if they do not.

The tests are too simplistic and don't contain any examples of concurrency.

Some ideas for examples to provide:

• A simple synchronous example
• Concurrent pinging against multiple servers with a configurable amount of workers (modeled after the Share Memory By Communicating codewalk)

Currently specific options are hardcoded into the ping messages. Ideally all the others would be supported.

• Standard ping options
• Extended ping options