jarodwr / se-process-and-tools Goto Github PK

Adding a booking in an invalid period currently works
Adding a booking with a non-existent customer currently works

It shouldn't work, test name: addNewBooking03().

Currently there is no validation for:
Service name
Service duration e.g negative duration, duration that isn't an increment of 30.
Service cost e.g negative cost

Probably comes from the fact the db is empty. We need a special case for this, as new businesses start off with an empty db.

Title explains it all. Here is the error trace:
http://screencloud.net/v/reWrz

Add customer with invalid username
Add customer with invalid phone number
Add customer without a password
Add customer without a username

If the booking doesn't exist, it should return false. It currently returns true.

test that is failing: getShift2().

There is a bug that whenever there is 3 or more working times, the third one is pushed to the following day when viewing them in the view working times owner's menu.

When converting the time from Unix time to a Java date, the time is always 14 hours behind. The current workaround is to add 14 hrs.

Can currently:
Add an employee with the same timetable ID as another employee
Add an employee with a duplicate ID
Add an employee to a non existent business

Due to how businesses are currently structured, you can eliminate the business variable.

This should be refactored considering that the way businesses are handled in the system is different. Removing bookings doesn't require the business variable anymore as there will be a business in focus when handling bookings.

Get employee booking availability for employee 3 after 2147410000 returns an availability when it shouldn't have any available times after that time.

Shouldn't be able to add a working time of duration 0

Shouldn't be able to remove a booking without referencing the business.

The way businesses are handled means we don't really need to reference a business anyway.

You shouldn't be able to add an employee without an owner.

Alternatively adding an employee should depend on the internal current business variable in utility.

Tests that are failing on the given db:
getBookingsAfter1()
getBookingsAfter2()
getBookingsAfter6()

Tests that fail on the supplied test db:
Get all bookings on or after 2147410000 for employee 3, which should be none
Get all bookings on or after 1497522600 for employee 3, which should be 1
Only booking available after 1497522600 for employee 3 should start at 1497508200
Get all bookings on or after 1497522601 for employee 3, which should be none