Comments (6)
I know it's not exactly what you are asking for but after
is merged it's possible to create a "generic" way to skip intros / credits sections, without any 3rd party plugins :)
from findroid.
@Natanel-Shitrit Assuming your video supports it, this also eliminates a lengthy scan that requires Chromaprint, but it just doesn't have that "Netflix" feel to it.
from findroid.
@Natanel-Shitrit Assuming your video supports it, this also eliminates a lengthy scan that requires Chromaprint, but it just doesn't have that "Netflix" feel to it.
Most of the shows that I have (Anime) have chapters, that might not be the case for "normal" shows.
You can integrate the chapters with the skip button if you want the "Netflix" feel - I just suggested to use the chapter info as the way of detection for the intro / credits 😄
from findroid.
It almost begs the question why literally everyone opted for Chromaprint, but not a single static ffmpeg for Mac enables it.
Anyway, that isn't why I was here. I was actually here to ... Edit: well, actually, here isn't the best place for it.
from findroid.
I guess you are referring to your discussion here jumoog/intro-skipper#52
I saw you said:
They are determining when the button is displayed on their end. I don't know if there is a check somewhere else, but it's essentially keeping the button visible the entire time the intro is playing.
And you linked this check:
Doesn't showSkipPromptAt
and hideSkipPromptAt
is given by the plugin?
So if you fixed the segment.IntroEnd
shouldn't it reflect on hideSkipPromptAt
?
GitHub only renders snippets from the origin repo 😢
from findroid.
Actually, no. Two different apps can use the same database, but interpret the values differently. That's what is happening.
This app is getting the value from the plugin, but not necessarily checking it the same way. At the time the plugin was written, it only supported an arbitrary dismissal time of the button. I added the option to keep it visible for the duration of the intro just recently.
The original plugin had an option to retain a section of the intro. It also accounted for the possibility that if the code defaulted to showing the button for the entire intro (it was a fallback back then), it would subtract that time. Oddly, though, this was done AFTER the end time was already determined for the button and only served to mark the playback value.
When using the option to retain the button for the entire intro, most of the original code gets ignored in favor of the raw intro times. The app checks every second, but the plugin is using 3 decimal places. The difference between when the value triggers the display in the app to stop and when the intro ends is somewhere between 1 - 2 seconds off, usually resulting in the button not disappearing right away. If there was intro left, it would likely go unnoticed.
TL;DR intro.hideSkipPromptAt - 1
from findroid.
Related Issues (20)
- Supporting Tizen OS HOT 1
- Add an option for storing downloaded movies in mulitple files HOT 3
- findriod can't connect to Ipv6 servers HOT 2
- The cover is too big
- Add option to set a default storage destination.
- "Hearing Impared" not shown in subtitle selection menu
- Findriod occasionally crashes after leaving video player HOT 5
- Long press for speed up HOT 2
- Additional parts of the movie are not shown
- [BUG] Purple screen when playing videos HOT 3
- Deleting downloaded content in offline mode raises a visible exception
- Findroid may occasionally jumps/skips next episode (E2) to other (E3 or more) HOT 1
- how to setup dev enviroment for android TV version? HOT 2
- Transcode downloads to save storage space
- Add Option to enable other Library types
- Zoom Control with Cutout
- Downloads to external storage always fail.
- support shaders for mpv for upscaling(Anime4k) HOT 1
- Broken endpoints for liking and marking as watched (possibly more) HOT 2
- Can't download video bigger than internal storage HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from findroid.