jaredhirsch / browserid Goto Github PK

Howdy,

I'm not sure of how to run tests, etc. I tried:

./node_modules/.bin/vows tests/change-password-test.js 
using local browser
····
node.js:201
        throw e; // process.nextTick error, or 'error' event on first tick
              ^
TypeError: Object TypeError: Cannot read property 'email' of undefined has no method 'replace'
    at parse (/Users/shout/Projects/browserid/automation-tests/node_modules/vows/lib/assert/error.js:133:20)
    at AssertionError.toString (/Users/shout/Projects/browserid/automation-tests/node_modules/vows/lib/assert/error.js:139:27)
    at runTest (/Users/shout/Projects/browserid/automation-tests/node_modules/vows/lib/vows.js:136:36)
    at EventEmitter.<anonymous> (/Users/shout/Projects/browserid/automation-tests/node_modules/vows/lib/vows.js:78:9)
    at EventEmitter.<anonymous> (events.js:88:20)
    at EventEmitter.emit (/Users/shout/Projects/browserid/automation-tests/node_modules/vows/lib/vows.js:237:24)
    at Array.0 (/Users/shout/Projects/browserid/automation-tests/node_modules/vows/lib/vows/suite.js:168:45)
    at EventEmitter._tickCallback (node.js:192:40)

On my Mac 10.7.5 after following the README.

I relocated run_saucelabs and run.py to a /bin directory. run.py is working, but run_saucelabs needs to be tweaked:

• ensure it works from its new directory location
• now that almost all the command-line options for pytest are inside pytest.ini, remove them from the list of things that run_saucelabs passes to the command line.
• in particular, since we're going to be handling baseurl differently going forward, we can remove that stuff as well.

for reference, take a look at the last run.py commit, which trimmed a lot of the fat out of that file.

the persona_server directory contained a lot of questionable code, like copy-pasted versions of bidpom, that in retrospect should probably not have been merged in as-is (my mistake for not looking more closely at it at the time).

I temporarily deleted that directory to get a clearer view of the code reorg earlier this week. This issue is to look at that temporarily deleted code, diff it against existing copy-pasted files to find useful non-duplicated bits, and merge those in.

in the old codebase, it was assumed that all tests run by a single pytest call would hit a single base url. this is an assumption built into the mozqwebqa pytest plugin.

in our new codebase, we collect tests into classes based on the feature exercised, not based on the target domain tested. this means that setting one baseurl for a given test run won't work. however, we will generally want to test either dev, or stage, or prod domains in a given run, so we can key our config to that.

One approach would be to hack on mozwebqa directly, and submit an upstream patch to allow an alternative to the --baseurl argument.

A more expedient hack would be to write another pytest plugin, which runs after mozwebqa plugin has run and created a test object to pass into a test method. The idea is to just hack baseurl in that object, reading from a config file. This is a bit heavy on magic, but doesn't require updates to other projects, so is probably the best short-term solution.[

in order to streamline our test organization, bidpom has been deconstructed and spread throughout the automation-tests pages, tests, and utils drectories. I was careful to separate out commits that changed locations and import statements, so theoretically those diffs could be removed from a branch's history and that would reconstruct bidpom for submitting patches upstream. However, the upstreamed blob doesn't need to retain history, so we could also straight-up piece it back together if git magic fails.

Goal: whether via git magic or a script to do the diffing/copying, make it easy to reconstruct bidpom for periodic upstreaming.