jaredcdavis / shellpool Goto Github PK

Sounds like I can get access to a mac mini for testing.

Perhaps the right way for the test suite to work is to have it be a separate defsystem, i.e., shellpool-test. Bordeaux-threads apparently uses this model, so that may be a good place to look to see how it is done.

A few things to do here:

• See if we can use a simpler thread-killing approach (e.g., do we really need this pgrp stuff)
• Develop tests of this stuff

We're stilling using CCL-specific code for running programs.

It would be nice to have a way to ensure that at least N shells are allocated, and only start up however many shells are needed to accomplish that.

Need to implement run-background and write some tests of it.
Want it to run commands in a sub-shell so that it can be robust, tolerant of shell errors, etc.

Talk to Xach about how to get shellpool into Quicklisp, once it's ported to SBCL and ready.

Now that shellpool is part of quicklisp the install instructions can be made simpler.

Now that the kill tests have been simplified and made single-threaded, it would be good to have some explicitly multithreaded tests to make sure things still work there.

Installed openbsd on a virtualbox. Should be straigthforward... if the mouse would work right.

I've recently realized that I'm encountering an issue with shellpool when using the RUN function.

For some reason, if my *default-pathname-defaults* is set to a path that contains a space character like #P"/Users/areinisc/reasonable path/on-macOS/" (see "reasonable path"), then the function RUN does not behave as expected.

For example:

$ sbcl
This is SBCL 1.3.18...
* (ql:quickload "shellpool")
...
* (shellpool:ensure 1)

NIL
* (shellpool:run "echo hi")
bash: /Users/areinisc/reasonable: No such file or directory

127
* *default-pathname-defaults*

#P"/Users/areinisc/reasonable path/on-macOS/"

I would expect (shellpool:run "echo hi") to print hi to *standard-output* and then return 0, but instead I get an error message from bash and the error code 127.

Thanks in advance for any help with this issue!

Shellpool doesn't seem to call the each-line function on the last line of output when running commands like echo -n hello. This seems like a bug.

It would be useful if an environmental variable might be customised by user during the bash start.
E.g.

(shellpool:start 7 :setenv '("FILENAME=/tmp/some-file.bat"))

In that way it would be possible to pass some pre-computing results into the pipeline.