jaredatch / bbpress-genesis-extend Goto Github PK

Since the layout options throw an error on the user profile edit page, it may be a good enhancement to deal with at least that in bbPress Genesis Extend.

if ( bbp_is_single_user_edit() ) {
     remove_action( 'show_user_profile', 'genesis_user_options_fields' );
     remove_action( 'show_user_profile', 'genesis_user_layout_fields' );
     remove_action( 'show_user_profile', 'genesis_user_seo_fields' );
     remove_action( 'show_user_profile', 'genesis_user_archive_fields' );
}

Hosting company is saying the below. When I look at the load_genesis_forum_sidebar I do not see how it would be running this query. Is there something there that I am missing?

Query:

SELECT wp_posts.ID FROM wp_posts INNER JOIN wp_postmeta ON ( wp_posts.ID = wp_postmeta.post_id ) WHERE ?=? AND ( ( wp_postmeta.meta_key = ? AND CAST(wp_postmeta.meta_value AS SIGNED) NOT IN (?, ?, ?, ?) )) AND wp_posts.post_type = ? AND ((wp_posts.post_status = ? OR wp_posts.post_status = ?)) GROUP BY wp_posts.ID ORDER BY wp_posts.post_date DESC LIMIT ?, ? ?
Obfuscated query SELECT wp_posts.ID FROM wp_posts INNER JOIN wp_postmeta ON ( wp_posts.ID = wp_postmeta.post_id ) WHERE ?=? AND ( ( wp_postmeta.meta_key = ? AND CAST(wp_postmeta.meta_value AS SIGNED) NOT IN (?, ?, ?, ?) )) AND wp_posts.post_type = ? AND ((wp_posts.post_status = ? OR wp_posts.post_status = ?)) GROUP BY wp_posts.ID ORDER BY wp_posts.post_date DESC LIMIT ?, ? ?

this is stemming from

wp-content/plugins/bbpress-genesis-extend/
bbpress-genesis-extend.php (Line 210)
in BBP_Genesis::load_genesis_forum_sidebar

https://wordpress.org/support/topic/threaded-replies-not-working?replies=3#post-8327756

Forum users with access to Genesis edit settings in their profiles (ie Administrators) see the following display issue when editing their profiles on the front end.

To prevent this, they can be removed unless viewing in the admin profile:

add_action( 'bbp_ready', 'bbp_genesis_extend_disable_genesis_profile_fields_in_forum_user_edit' );
function bbp_genesis_extend_disable_genesis_profile_fields_in_forum_user_edit(){

    if( ! is_admin() ) {
        remove_action( 'show_user_profile', 'genesis_user_options_fields' );
        remove_action( 'edit_user_profile', 'genesis_user_options_fields' );
        remove_action( 'show_user_profile', 'genesis_user_archive_fields' );
        remove_action( 'edit_user_profile', 'genesis_user_archive_fields' );
        remove_action( 'show_user_profile', 'genesis_user_seo_fields' );
        remove_action( 'edit_user_profile', 'genesis_user_seo_fields' );
        remove_action( 'show_user_profile', 'genesis_user_layout_fields' );
        remove_action( 'edit_user_profile', 'genesis_user_layout_fields' );
    }

}

Jared, have you thought about using the genesis_init hook instead of the after_setup_theme hook in your init class? This has a couple of advantages. First, I've run into weird issues where from time to time the template is Genesis but I get a white screen because genesis_get_option() is not found. It seems that in very weird cases the logic that loads certain files doesn't seem to complete. Most recently this happened to me when doing a WP update. It isn't super common and seems to rely on several factors but it is kind of annoying when it happens. Using genesis_init should bypass that.

Also, using genesis_init means that you don't have to check the template constant to see if it is Genesis. That will ever so slightly simplify the code.

This may be from a combination of plugins or from using some bleeding edge code but bbPress was crashing to an out of memory error for me and no matter how much memory I opened up it happened. I was able to narrow it down to bbPress Genesis Connect and then from there to the site_layout option filter.

It looks like you are checking the original site_layout value and that is causing the filter to keep running recursively. A flag can be added to the class to verify the filter only completes once.

bbpress Genesis Extend hasn't been updated in 4 years.

I've had little success getting bbpress to work correctly with Genesis + Dynamik Website Builder. Mostly to do with permalinks and forum account page not working or displaying correctly.

Is this plugin still viable/needed? Any advice on Dynamik + bbpress?