Coder Social home page Coder Social logo

janosgit / schrammel_ojd Goto Github PK

View Code? Open in Web Editor NEW
157.0 157.0 19.0 12.91 MB

Audio plugin model of a modern classic guitar overdrive Pedal

Home Page: https://schrammel.io

License: GNU General Public License v3.0

CMake 8.92% Inno Setup 0.79% C++ 90.29%
guitar-effects guitar-overdrive juce juce-framework vst-plugin vst3

schrammel_ojd's People

Contributors

janosgit avatar lgoodacre avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

schrammel_ojd's Issues

FR: Stereo mode

Hi Janos,
It would be great if you could add a stereo mode switch to your great OJD plugin.
I'll often use it on a stereo pair of guitars and currently it means making adjustments to both while tweaking the sound.

I'm fully aware this will double CPU usage, but clearly no worse than 2 separate instances.

Also, the bypass button is pretty tiny. Would you consider making a larger target, please? (Or if you want to keep the GUi the same, perhaps also add the 'power LED' as a hit area for the bypass switch.)

All the best,
Dax.

Building on linux fails

I am trying to build it on Linux Mint and I get the following error:
$ cmake -DCMAKE_BUILD_TYPE=Release -B build
-- The C compiler identification is GNU 11.3.0
-- The CXX compiler identification is GNU 11.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:39 (add_subdirectory):
The source directory

/home/marcello/Documents/Softwares/schrammel_ojd/Ext/JUCE

does not contain a CMakeLists.txt file.

CMake Error at BinaryResources/CMakeLists.txt:24 (juce_add_binary_data):
Unknown CMake command "juce_add_binary_data".

-- Configuring incomplete, errors occurred!
See also "/home/marcello/Documents/Softwares/schrammel_ojd/build/CMakeFiles/CMakeOutput.log".

How can it be fixed?

Thanks

[Feature request] StudioRack integration

It's an open-source plugin manager called StudioRack:
https://github.com/studiorack

The aim of the project is to provide a free open-source way to manage plugin dependencies and their versions. It would involve the following steps:

Publish a Github release containing the plugin source along with metadata plugins.json
Tag your Github repository with studiorack-plugin so it can be discovered
Wait for the studiorack-registry to index your plugin (every 24 hours)
Check the registry feed for your plugin to appear

missing CMakeLists.txt file?

CMake Error at CMakeLists.txt:37 (add_subdirectory):
The source directory

./Schrammel_OJD/Ext/JUCE

does not contain a CMakeLists.txt file.

Add an AAX version

Need to figure out how I can get it signed correctly and then how this process can be automated by the build pipeline without violating the AAX NDA by exposing build steps covered under NDA

OJD causes SIGSEGV in Ardour on Linux

Hi,

I did a fresh install of Debian Testing, with Ardour 8.4.0, and fresh compile of OJD. When I load a project that uses OJD, Ardour crashes. I ran it in the debugger and found this:

Thread 52 "ArdourGUI" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff7b5ff6c0 (LWP 22706)]
0x00007fff7b830da4 in juce::TextEditor::setText(juce::String const&, bool) () from /home/dana/.vst3/OJD.vst3/Contents/x86_64-linux/OJD.so

Build output folders are created wrong

With the change to separate targets for each plugin format the output directory of the build stage has a new folder structure which lets the installer building stage fail.

Rework Resvg4JUCE to be built via CMake

In order to achieve builds that can be triggered completely via CMake, the underlying resvg rust library contained in Resvg4JUCE has to be built through CMake as well and should export a nice CMake target

macOS installer: Don't force restart after installation

This setting was originally chosen because of the issues reported here. Multiple users reported this as unexpected behavior, so this should be removed with the next update. Investigating the killall -9 AudioComponentRegistrar solution reported on the juce forum instead.

building fails on Linux/gcc, ambigous conversion error

Steps I took to try and build this:

  • git clone --recursive https://github.com/JanosGit/Schrammel_OJD.git
  • mkdir build
  • cd build
  • cmake ..
  • make

The two errors I got:

In file included from /home/billydm/Downloads/Schrammel_OJD/Ext/JBPluginBase/jb_plugin_base/jb_plugin_base.h:90,
                 from /home/billydm/Downloads/Schrammel_OJD/Source/OJDPedalComponent.h:24,
                 from /home/billydm/Downloads/Schrammel_OJD/Source/OJDPedalComponent.cpp:22:
/home/billydm/Downloads/Schrammel_OJD/Ext/JBPluginBase/jb_plugin_base/Utils/MessageOfTheDay.h: In lambda function:
/home/billydm/Downloads/Schrammel_OJD/Ext/JBPluginBase/jb_plugin_base/Utils/MessageOfTheDay.h:108:76: error: conversion from ‘const int64_t’ {aka ‘const long int’} to ‘const juce::var’ is ambiguous
  108 |      int64_t updateVersion = update.getProperty ("Version", currentPluginVersion);
      |                                                             ^~~~~~~~~~~~~~~~~~~~
In file included from /home/billydm/Downloads/Schrammel_OJD/Ext/JBPluginBase/jb_plugin_base/jb_plugin_base.h:90,
                 from /home/billydm/Downloads/Schrammel_OJD/Source/OJDPedalComponent.h:24,
                 from /home/billydm/Downloads/Schrammel_OJD/Source/OJDPedalComponent.cpp:22:
/home/billydm/Downloads/Schrammel_OJD/Ext/JBPluginBase/jb_plugin_base/Utils/MessageOfTheDay.h:115:81: error: conversion from ‘long int’ to ‘const juce::var’ is ambiguous
  115 | int generalMessageVersion = general.getProperty ("Version", lastVersion);
      |                                                             ^~~~~~~~~~~

I think you need to explicitly put in what type const juce::var is for this to compile on gcc.

Output Volume is a bit to low in its default setting

A few users reported this on various channels, inserting the plugin on a channel with default settings leads to a noticeable volume drop. Probably the default volume for a fresh instance should be increased a bit

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.