janhavisinghh / popular_movies

Udacity Project

Popular_Movies

Udacity Project

This app shows a list of Popular Movies from themoviesdb API.
You can sort the list by Highest Rated, Most Popular, and Favourite Movies.

You can see the details of every movie. The trailer, Reviews, Rating, etc.

You can also favourite and un-favourite a movie.

And sort the list and go to your Favourited Movies.

To run the project go to https://www.themoviedb.org/ and build an API KEY.
Then, put your API KEY in NetworkUtilities.java(35).

popular_movies's Issues

Single Responsibility

SOLID principles are very important aspect of programming.
The S in SOLID means, Single Responsibility of the class.

You can take an example of TrailerAdapter

It is doing the following:

• Being an adapter
• Holding the ViewHolder class
• Logic in onBindViewHolder() on the ViewHolder, which is sharing the trailer.

What we'll do is move the 2nd and 3rd item to a separate file called TrailerViewHolder . The click listener in onBindViewHolder() will also move to this file as well.

Create a branch of this issue name(like this issue-NUMBER) from master and when it is done. Push it.