jamiembright / csd-library Goto Github PK

The 10th column is a Matlab timestamp. It appears to me that these timestamps aren't aligned with the data either in local or UTC time.

to recreate:

load('sample_data.mat')
plot(data(1:1200, 10), data(1:1200, 2))
datetick('x')
grid on
xlabel('Time')
ylabel('GHI clear')

Both declare BrightSun2020CSDc

The high zenith limit for the line length criterion (c3) is 0.5 in the code, but in the JRSE paper it is given as 2. Which is recommended?

The calculation of c1_lim appears different than described in the JRSE paper.

This calculation produces c1_lim that has a break at zenith=80, rather than at zenith_turn_around = 30 as described in Table 3 of the paper.

>> plot(z, c1_lim)
>> xlabel('z')
>> ylabel('c1\_lim')

Should there be a flipud(z) in the function somewhere? Flipping z produces the right picture:

>> plot(flipud(z), c1_lim)
>> xlabel('z')
>> ylabel('c1\_lim')