jamesmessinger / json-schema-lib Goto Github PK

Hello! 👋

Preface

I know that this library is still in pre-alpha and very much not ready for production, but I've been looking into using it anyway because my code is currently reliant on using deasync to force json-schema-ref-parser to behave in a synchronous manner, and deasync is causing segfaults (!) so I need to migrate my code to something else as soon as I can.

I specifically only need synchronous parsing of local files. I don't use any remote schemas that require HTTP requests.

The Actual Issue

During my testing of json-schema-lib, I noticed FileSystemPlugin.js#L150, which calls decodeURIComponent on the file path. Was this meant to be encodeURIComponent, instead of decode?

I have some files such as schema%3Astate.json which are already URI encoded. But, when passing these paths to json-schema-lib, the paths gets decoded such that they are now pointing to files that don't exist. For example: schema%3Astate.json becomes schema:state.json, which is not a valid Windows filename.

If this is indeed unintended behavior, I would be happy to open a small pull request to change it.

Thanks for all your work on both this and the original json-schema-ref-parser!