Coder Social home page Coder Social logo

ripple's Introduction

ripple's People

Contributors

jamband avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

amenalseady2

ripple's Issues

Enhanced Ripple::embed()

It's the following code and undefined index occurs.

$url = 'https://www.youtube.com/watch?v=S7_jxl6TO6w';

$ripple = new \jamband\ripple\Ripple($url);
$ripple->request(new \Goutte\Client());
$ripple->setEmbedParams(['Bandcamp' => 'size=large/']);

var_dump($ripple->embed($ripple->provider, $ripple->id()));

Even if the parameters of a particular provider is undefined, it should not issue a notice error.

Change arguments of Ripple::embed() method

before:

$url = 'https://example.bandcamp.com/album/title';
$ripple = new jamband\ripple\Ripple($url);
$ripple->embed($url, 'Bandcamp', '456');

after:

$url = 'https://example.bandcamp.com/album/title';
$ripple = new jamband\ripple\Ripple($url);
$ripple->embed($url, '456'); // Delete provider name argument

This change will BC break.

Major changes in API

$ripple = new Jamband\Ripple\Ripple;
$ripple->options(['curl' => [], 'embed' => [], 'response' => []]);
$ripple->request('https://example.com/track/title?foo=bar');

$ripple->provider(); // Provider name or null
$ripple->url(); // https://example/com/track/title or null
$ripple->id(); // id or null
$ripple->title(); // title or null
$ripple->image(); // https://image.example.com/123.jpg or null
$ripple->embed(); // https://example.com/embed/123 or null

This change will be released in version 0.7.0.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.