jakobw / wd-query-builder Goto Github PK

Currently, it is already possible to combine multiple values for a property, e.g. using the "any item matching" option in the dropdown menu.

It would be nice to have a way to also combine properties using such an "any" relationship, i.e. combining different properties with OR rather than AND.

For example, I'd like to query for items that have either the "country" or "country of origin" property set to a specific country.

FILTER NOT EXISTS would be what I this option to output into the query but it just looks for any object with that value which is excatly what it isn't supposed to do

When "x" (delete) a property value pair, nothing happens and console shows an error of Error in event handler for "remove": "TypeError: _vm.statements.splice is not a function

The autosuggest for properties results in "No properties found" and spawns an error on the console: Loading failed for the <script> with source “https://www.wikidata.org/w/api.php?action=wbsearchentities&continue=0&format=json&language=en&search=a&type=property&uselang=en&callback=__jp0”.

(Firefox 56, Linux, npm run dev)

There should be a link on the tool's page (https://tools.wmflabs.org/wd-query-builder/) to this repository, and likewise, the README in the repo and the url (editable in the settings in the github interface) should link to the live tool page.

I can contribute the changes to the README and to the html page, but the repository settings can only be changed by the repo owner.

There's no easy way currently to clear the current query. I think there would be two options to make this possible:

1. An easy way: make the title of the query builder link to the root (wd-query-builder.toolforge.org) so you can just click it and it will automatically clear the query (this is how i do it in VizQuery)
2. A more advanced way with a button somewhere near the 'Share Query' button that clears the current query. This should probably give a warning / alert to confirm the deletion of the current query.

1. Add a filter for any statement, e. g. “instance of: Wikidata”.
2. Add a qualifier filter for any property, e. g. “end time”.
3. For the qualifier value, select “does not exist”.
4. Click “show results”.

Expected: results show up. (In this case, 0 results, but something should still happen.)

Actual: Nothing happens (no WDQS embed), and there are two errors in the console:

1. When you select “does not exist”:

   [Vue warn]: Error in callback for watcher "valueType": "TypeError: specialValue.classConstructor is not a constructor"

   found in

   ---> at src/components/ValueSelector.vue
   at src/components/Qualifier.vue
   at src/components/Statement.vue
   at src/components/StatementList.vue
   at src/App.vue
   
   vue.esm.js:578
   TypeError: specialValue.classConstructor is not a constructor
   Stack trace:
   newValue@webpack-internal:///22:21:16
   valueType@webpack-internal:///41:126:26
   run@webpack-internal:///1:3207:11
   flushSchedulerQueue@webpack-internal:///1:2955:5
   nextTick/<@webpack-internal:///1:1814:9
   flushCallbacks@webpack-internal:///1:1735:5

2. When you click “show results”:

   [Vue warn]: Error in nextTick: "TypeError: qualifier.getValue(...) is undefined"
   vue.esm.js:578
   TypeError: qualifier.getValue(...) is undefined
   Stack trace:
   addQualifierTriples@webpack-internal:///142:59:87
   generateQuery@webpack-internal:///142:25:7
   generateQuery@webpack-internal:///51:56:14
   boundFn@webpack-internal:///1:192:9
   showResults/<@webpack-internal:///51:72:24
   nextTick/<@webpack-internal:///1:1814:9
   flushCallbacks@webpack-internal:///1:1735:5