jakeisnt / verde Goto Github PK

one button should subtract, as the buttons are '+1' and '-1'!

I don't think it makes sense to cache these, but these calculations shouldn't be repeated many times on the front-end.

"TODO: combination of useUser and useSocket hook that provides some user data"
Is this worthwhile?

to onboard people onto the project and encourage greater participation, documentation has to be enhanced and updated to ensure that people new to javascript, react, whatever they want to work on in this repository is easy to use and well documented

Currently, the state of each user is broadcast to every single user (or not at all). This is not ideal. Users need to be able to have some private state (for example, their hand in a game of cards), as well as a public state that is visible to everyone.

This requires:

• A way to individually message users or a way to encrypt data that only one of the users can decrypt
• A way to separately store public and private user state in the Game engine
• API modifications to make it easy to work with. Explore existing ideas for this!

Worth considering:

• More settings for the game API to enable/disable these behaviors

https://www.are.na/block/10509270/

good starter game with motivation for extending the capability of the api

ie: client is loaded but the user doesn't have internet connection or the server isn't started, and the client isn't currently in a room

• catch the http error rather than letting it silently fail and print to console
• send the client back to the main page
• show the client an error telling them that they've been disconnected from the network

annoying to have to restart the nodejs server every time a change is made. would much rather just punch in the code and have it reload for us

more space efficient and much more quickly parsed

• this branch of capnproto looks good capnproto/capnproto#1229
• protobuf option (better support) protobufjs/protobuf.js#689

when the moderator ends the game, regardless of score the mod is displayed as the winner

the 'game.js' configuration object should have two optional fields to specify the minimum and maximum number of players for a game. the max number of players is min(moderator declared max, server declared max).

• the maximum number of players should be presented to the person creating the room while they choose the (optional) number of players
• when the maximum number of players has been reached, the server should refuse to add any more players to the game. any spectators are stuck as spectators and cannot be made players by anyone.
• when the minimum number of players is not met, the game cannot be started until there are at least that many users; the 'start game' button should be greyed out with a tooltip or other message on the client side until the minimum number of players constraint has been met.

get error 'cannot read property clickedLast of undefined' when:

to reproduce (sometimes?):

• start game in client a and take some actions
• connect with client b
• take more actions in client a

it is currently a commonjs module and can likely be upgraded to use - at the least - consistent import and export syntax.

Store private game logic that can be seen by the game configuration language on the server side but not by any client.

currently, if the game is started by some player 'a', if some player 'b' joins the game and player 'a' doesn't take any actions, player b is shown 'waiting for the game to start...' rather than the current gameState, as the websocket hasn't sent the game state to player b yet

totally doable with the current game state, though may be annoying to implement the frontend
dependent on #34, as games can only have two players

when refreshing main page, url doesn't change, so any previous error (as stored in url) will still be shown. it's not necessarily relevant after a refresh so this might be cconfusing to users

https://github.com/boltpkg/bolt

this is likely because no players exist after the game is over, so there is no player to reference
quick fix - null checking more - has been made, but there is more to investigate here

not necessarily all of them - just ones people will play

switch to using winston from morgan
replace all console logs with calls to winston
hide all logging on frontend in prod, minimal on backend

after creating a game and clicking the '+1' button the score cannot drop below 0; likewise, if the '-1' button is initially pressed, the score cannot drop below 1, though '+1' and '-1' appear to otherwise function as intended in both scenarios