jahed / night-patrol Goto Github PK

The Babel dependencies are out of date after Babel 7 was released and no longer follow best practices like using preset-env. Also eslint is out of date and I prefer standard-js's simplicity.

Instead of upgrading Babel and eslint, this is a good opportunity to move the project over to TypeScript.

Currently, Night Patrol loads the configuration only on start up. This means changes to the test suite (new/removed test files, new/removed test cases, changes nightwatch config, etc.) aren't loaded in and requires the user to manually restart the executable. This is inconvenient. Ideally, watch for changes and reload the configuration whenever a change is detected.

To be safe and to keep it simple, any change should reload the entire configuration, not just parts of it, unless if this introduces performance issues.

Changes which should trigger a reload:

• Changes to nightwatch config
• Changes to any directory and children referenced by nightwatch config which is used by Night Patrol (just src_folders for now)
• Changes to nightwatch executable (version check)

Vorpal.js is barely maintained and has out of date dependencies, some with security alerts (though it's mitigated by using more recent versions in night-patrol since they're caret versions).

Vorpal is just a layer over Inquirer so it can switch to that with some work.

Nightwatch supports setting src_folders to an array, but Night Patrol assumes it's always string.

$ night-patrol --config ./tests/nightwatch.config.js
path.js:39
    throw new ERR_INVALID_ARG_TYPE('path', 'string', path);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
    at assertPath (path.js:39:11)
    at Object.resolve (path.js:1088:7)
    at setNightwatchConfig (/home/jahed/repos/frontiernav/frontiernav/node_modules/night-patrol/dist/actions/nightwatch.js:73:40)
    at Object.<anonymous> (/home/jahed/repos/frontiernav/frontiernav/node_modules/night-patrol/dist/cli.js:208:46)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
    at Function.Module._load (internal/modules/cjs/loader.js:529:3)
    at Module.require (internal/modules/cjs/loader.js:636:17)

stripcolorcodes is just a one-liner. Re-implement it instead.