jacobdb / pwa-install-prompt Goto Github PK

Hi, thanks for sharing this resources.

I try with your library in my project and not work.

I execute the code ni mounted() in Vue.

`

https://developers.google.com/web/fundamentals/app-install-banners/

Overlay should be the only button, the x can be a pseudo element on the prompt.

• Focus the prompt when it gets opened
• Close the prompt when focus is lost
• Add aria properties

Should document .on, .open, and .close for others to use.

iosInstallPrompt.destroy();

The idea is to completely remove the element from the page if it's destroyed. I'm not sure if this the appropriate way to do this, or if this would be better handled by users with the upcoming .close() method.

• iosInstallPrompt.on("open", function (container) { ... }
• iosInstallPrompt.on("close", function (container) { ... }

Apparently the banner that pops up at the bottom of Chrome is a temporary solution, and developers can provide their own. This package should be refactored to support this better.

Hi, thanks for sharing this resources.

I try with your library in my project and not work.

I execute the code ni mounted() in Vue.

........................................................

thanks!

Currently it seems like screen readers can probably still access it, should mark it with visibility:hidden; when it's inactive.

This should make it easier for users to understand what to do.

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share

It currently just appears and disappears, it doesn't feel very smooth.

Should allow a bit more customization, like switching from display: none; to display: block; just before the prompt opens.