jacketizer / libyuarel Goto Github PK

An absolute path without host should be a valid url. Unfortunately yuerel_parse() fails in this case.

Hi!
I tried this library in my Lwip stm32f4 webserver project, it works fine but if add user name/password, then not work, I think need modification for making it work with example mentioned below
"http://admin:[email protected]:8989/path/to/test?query=yes&param1=no#frag=1"

Nitpicking ;)

The README.md ("How to use it") is missing the definition of params:

struct yuarel_param params[3];

otherwise it won't compile.

Hi,
This is not really a problem for my case, but I'm reporting it just FYI.

http://[2001:4860:0:2001::68]/foo/bar?a=123
Struct values:
        scheme:         http
        host:           [2001
        port:           574336293
        path:           foo/bar
        query:          a=123
        fragment:       (null)
Could not split path!

Hello, I found an error when 1 struct yuarel_param is passed to the yuarel_parse_query() function.
They are not working properly.

		char* query = "a=b&c=d";
		yuarel_param params;
		yuarel_parse_query(query, '&', &params, 1);

		// HERE
		// params.key == "a"
		// params.val ==  "b&c=d"

Hi, thanks for sharing your code! I'm dumping a one-off parser I wrote myself in another project for yours.

One issue I found is it seems the code that parses credentials requires both user and password.
E.g. http://u:[email protected] works, but http://[email protected] does not.

Does this look like the right fix?

diff --git a/yuarel.c b/yuarel.c
index a5f313fb7..072bd76ad 100644
--- a/yuarel.c
+++ b/yuarel.c
@@ -180,12 +180,11 @@ yuarel_parse(struct yuarel *url, char *u)
                        *u = '\0';
 
                        u = strchr(url->username, ':');
-                       if (NULL == u) {
-                               return -1;
+                       if (NULL != u) {
+                               url->password = u + 1;
+                               *u = '\0';
                        }
 
-                       url->password = u + 1;
-                       *u = '\0';
                }
 
                /* Missing hostname? */

Maybe the Read.me could be updated with the notion that the original string will be modified during the parsing proces?
I noticed my original string after parsing containing only "http" after parsing was done. I still need my original string after parsing, so I pulled a copy using malloc().
I assume you do not want a malloc() call in your lib? So you deliberately do not make a local copy, am I right?