Coder Social home page Coder Social logo

Comments (1)

p-mcgowan avatar p-mcgowan commented on June 16, 2024

if eslint insists that process.exit is bad, then the error could either be traced and re-thrown, or just left uncaught.

I could see it being the case if the source was imported and used programatically, but the cli should catch it's own errors, and exit - AFAIK i don't see a use for importing the cli into another node script

additionally, bundleSwaggerParse catches it's own error and does not propagate it - resulting in logging the error and the process continuing on:

// bundlerSwaggerParse.js:47 bundler json stringify bundled
undefined  
// bundlerSwaggerParse.js:48 bundler log error
{
  stack: 'ResolverError: Error opening file "something.yml" \n' +
    "ENOENT: blah blah stacktrace",
  source: 'something.yml',
  path: [],
  toJSON: [Function: toJSON],
  ioErrorCode: 'ENOENT',
  name: 'ResolverError',
  toString: [Function: toString]
}
// cli.js:59 error was caught, logged, not re-thrown, so the cli continues on and tries to colourize and report success
Trace: TypeError: Cannot read property 'green' of undefined
    at swagger/node_modules/boats/src/cli.js:59:104
    at swagger/node_modules/boats/src/cli.js:62:11

from boats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.