Coder Social home page Coder Social logo

Comments (4)

p-mcgowan avatar p-mcgowan commented on June 21, 2024

yeah that's a good call.
In this case, I think it would be good to have 2 setups here - 1 for skip and ignore, and 1 for auto yes.

The reason being - while running tests, if you allow it to ping the remote every time, it can be slow. In this case, we could keep the NODE_ENV=test workaround for skipping it completely, but the --yes here could still do the check, but just report the difference.
In this case, I think a simple remote version check would suffice, or even a basic http call. Otherwise we may need to dig into the version checker and find out if it's easy to pass in some flags / env vars to disable it at certain points.

from boats.

Acrontum-Carmichael avatar Acrontum-Carmichael commented on June 21, 2024

the npm version checker could easily be extended - might be a simpler solution.. open to changing it

from boats.

p-mcgowan avatar p-mcgowan commented on June 21, 2024

I don't think the CI pipe was an issue - that we could use the new --yes flag for.

I initially hardcoded in if (process.env.NODE_ENV === 'test') { <skip thinger> } because it messed with running tests. It makes sense (in my mind at least) that in test env, it should not check for updates, and when not in test env, you can disable the complaining by --yes'ing it out. I think that should cover the use cases

from boats.

p-mcgowan avatar p-mcgowan commented on June 21, 2024

close in #28

from boats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.