Coder Social home page Coder Social logo

ivanvorobei / spconfetti Goto Github PK

View Code? Open in Web Editor NEW
295.0 2.0 21.0 6.25 MB

Show the confetti only when the user is having fun, and if not having fun, don't show it.

Home Page: https://opensource.ivanvorobei.io

License: MIT License

Swift 98.52% Ruby 1.48%
swift view confetti confetti-animation confetti-view uikit particles xcode ios swiftconfettiview

spconfetti's People

Contributors

gongzhang avatar ivanvorobei avatar krishbee avatar rogue85 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

spconfetti's Issues

required a higher minimum deployment target

Xcode 12.5.1
pod 1.10.1
swift 5
development version 11 or 12
platform :ios, '12.1'

pod install
Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "SPConfetti":
  In Podfile:
    SPConfetti

Specs satisfying the `SPConfetti` dependency were found, but they required a higher minimum deployment target.

Displaying over Sheets

Describe the problem that you catch
A clear and concise description of what you want to do.
Hey, is it possible to display the confetti over a sheet?
After the first start of the app and displaying the sheet, the confetti is getting displayed over it, after reopening the sheet, it's getting displayed behind it. It's kinda problematic to share a video with you, because I have to blur out all personal data, but If you really need it, I can do it.
I would be glad if you could help :)
Thanks!

Explosion effect

Hi,
I would like to ask if it would be possible to add an animation that starts from the center of the screen and then makes confetti fall downwards (think of it as an explosion effect: confetti starting from the center of the screen and spreading in all directions before falling down after a few seconds).
The explosion effect could start from the center of the screen or even better, from a specified view, button, or another element passed as a parameter.

Thank you

SPM: Couldn’t check out revision "fd172fe3cc07572e546942cb175b16e549fc3e1a"

Details

  • Xcode 13.4
  • Framework Version 1.4
  • Installed via SPM

Describe the Bug

Hi Ivan,

I have encountered a strange problem. When I add Package Dependencies in Xcode's Project Setting, the SPM seems to resolve the latest SPConfetti to an incorrect revision. I use the Xcode default settings when adding dependency.

image

However, the revision in the Package.resolved file points to fd172fe3cc07572e546942cb175b16e549fc3e1a, but this commit seems to be incorrect. There is also a warning on GitHub page for this revision: fd172fe3cc07572e546942cb175b16e549fc3e1a.

// Package.resolved
      {
        "package": "SPConfetti",
        "repositoryURL": "https://github.com/ivanvorobei/SPConfetti.git",
        "state": {
          "branch": null,
          "revision": "fd172fe3cc07572e546942cb175b16e549fc3e1a", // <=== 🤔
          "version": "1.4.0"
        }
      },

This issue can cause SPM to fail to checkout dependencies when building with CI. I can mannually edit Package.resolve to workaround the issue. But it will be great to fix it from the repo.

testflight bug

Details

  • iOS Version [e.g. 15.2]
  • Framework Version [e.g. 1.0.2]
  • Installed via [e.g. SPM, Cocoapods, Manually]

The library not working on testflight releases.
I have change the ios version from 14.7 to 16.0 but it doesn't fix the problem. not test on app store yet.
could you please check and guide me to solve the problem?

Failed to archive build with latest SwiftUI code

Describe the bug
Hi, Ivan, I just noticed the latest SwiftUI code break the SPM build. (-。-;

To Reproduce

  1. In Xcode, select the "iOS SwiftUI Example" target and build for "Any iOS Device"
  2. Product menu > run Archive
  3. The compiler will report errors related to SwiftUI symbols.

image

Resetting Global color in config does not work as expected

  • iOS Version: 17.2
  • Framework Version: 1.4.1
  • Installed via SPM

Context:
I show different confetti in various places of my app. I like to use the Globals for easy use.

Problem:
When I set the global SPConfettiConfiguration's color for the first time, it works:

SPConfettiConfiguration.particlesConfig.colors = [.red]

But when I reset it to some other color, the next confetti animation remains the color that was set in the first place.
Here's an example:

func rainHearts() {
   SPConfettiConfiguration.particlesConfig.colors = [.red]
   SPConfettiConfiguration.particlesConfig.contentsScale = 0.60
   SPConfetti.startAnimating(.fullWidthToDown, particles: [.custom(UIImage(systemName: "heart.fill")!)], duration: 3)
}
    
func rainConfetti() {
   SPConfettiConfiguration.particlesConfig.colors = [.yellow]
   SPConfettiConfiguration.particlesConfig.contentsScale = 0.5
   SPConfetti.startAnimating(.fullWidthToDown, particles: [.triangle, .arc, .heart, .star, .custom(UIImage(named: "Trophy")!)], duration: 3)
}

self.rainHearts() /// this rains `red` hearts perfectly
self.rainConfetti() /// this rains triangle, arc, heart, etc but in `red` color, when I expect it to be `yellow`

I even tried setting the SPConfettiConfiguration to it's default value:
SPConfettiConfiguration.particlesConfig = .defaultValue

That did not work.
Am I doing something wrong or is this a bug?
Either way, any suggestions?

iOS 15.5 Bug: Confetti does not appear

Details

  • iOS 15.5
  • SPConfetti 1.4.0
  • Installed via Cocoapods

Describe the Bug
Confetti does not appear on devices with iOS 15.5. The startAnimating call is simply ignored without errors.

Colors are wrong

Hi,
When I choose colors, the result is not good, all displaying colors cells are more dark, than the original color chosen.
For example a yellow this one, FCB700, become totally orange in cells.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.