Coder Social home page Coder Social logo

ivanruvalcaba / multi-keywords-highlighter Goto Github PK

View Code? Open in Web Editor NEW
18.0 8.0 5.0 462 KB

Highlights given keywords on any web page you visit —Mozilla Firefox Add-on—

Home Page: https://addons.mozilla.org/en-US/firefox/addon/multi-keywords-highlighter/

License: GNU General Public License v3.0

CSS 9.96% JavaScript 70.33% HTML 19.71%
firefox firefox-addon highlighter webextension

multi-keywords-highlighter's People

Contributors

ivanruvalcaba avatar sebbadk avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

multi-keywords-highlighter's Issues

Crash on empty keyword

When the keyword list contains an empty word (e.g. because the list ends in a comma) it probably tries to match EVERYTHING.

The only way out is killing and restarting the browser, and before all the tabs are restored, fix the plugin keywords.

Why would any sane person do that? It happened accidentally. I had a list of words in my editor, one on each line so I could sort and remove duplicates with the editor. I replaced the newlines between the words to commas, not realizing that there's a newline after the last word. I copy/pasted the line (now too long to fit on my screen) quickly into the plugin. Moreover, I do this a lot in Java, which plainly ignores trailing commas in array initializers, so it's become a habit.

Request: Port to Chrome.

Acknowledgement of difficulty:
This request recognizes that porting any program is a huge undertaking and requires a lot of time and effort typically by multiple people as well as generating the teams necessary to maintain the port moving forward.

Claim:
That being said, it should at the very least be noted that this version of a highlighter might dominate the competition in the Google Chrome market place as so far there doesn't appear to be another add-on in that market that can do what this one is currently capable of doing. Some come close, but actually can't highlight phrases, or they use the same color for all the highlights, or they are difficult for some users, etc.

Credentials for making the above claim:
My credential for making such a claim is that I have tried the majority of add-ons in the chrome market place that can perform highlighting for the purpose of finding search results, and according to the comments on those add-ons and my own testing of them, your add-on ("multi-keywords-highlighter", after adding another poster's feature request for jumping forwards and backwards through the highlighted text) would on first glance appear to meet the needs being requested by the Chrome community myself included.

Feature Requested:
If you have enough time, or if enough developers get involved, then please port this add-on to the Google Chrome web-browser.

Thanks.

Questions

Do you plan to support regex search terms?

Can i change the search terms while browsing?

Also: when multiple occurences are found, can i copy all of them at once?

Page not colored if another tab is active

Refresh one tab that contains keywords, then before it refreshes, select another tab or another window. Now THAT window gets re-highlighted instead. The page being refreshed isn't highlighted at all.

Request: connection to search box

A common usage scenario beneath the sticky keyword list across all pages could be that a user starts searching with Firefox's search box. After that he wants to highlight the search terms to be able finding the important parts of the page easier.

If there would be a mode where the keywords wouldn't need to be entered manually this could be achieved. My thoughts are going in this direction:

• Click on the icon reads the current search terms from Firefox's search box, adds them silently to the highlighting keywords and starts the highlighting
• Click on the icon with a modifier key clears all highlighting keywords

Request : control over colors

I used a legacy add-on called Multiple-highlighter which is similar to this one except instead of assigning a random color to each expression, it lets you type expressions in multiple rows, one for each color (but you can still type multiple expressions in the same row). That was really powerful but now that Firefox Quantum is out and has disabled all legacy add-ons, I have to find an alternative and your add-on seems to be the closest.

Regexp will be great

or is there a way to to distinguish a character alone from part of a word

(example I would like to highlight all emails in priority 1, but no all dates containing a 1 (2018-01-01) )

High-dpi bug

It's not multi-DPI compatible.

I have two screens, one high-DPI, one normal. On the high-DPI screen it works fine. On the normal screen it flips out under certain circumstances (it didn't happen to me the first time I entered a keyword, but all times after). If it matters, the main screen is high-DPI.

Vid: https://youtu.be/TlvNCMTcnM8

Doesn't seem to match across elements?

This, from spanish.kwiziq.com...

<span class="test-questions__hint">HINT: Conjugate "saludar" in El <span class="highlighted style-3" style="">Presente</span> <span class="highlighted style-3" style=""><span class="highlighted style-3" style="">Subjuntivo</span></span></span>

appears on the page as this...

HINT: Conjugate "saludar" in El Presente Subjuntivo

and I want to match "Presente Subjuntivo". But I can only match the two words separately. Not together with a space between them. I mean if the keyword list contains ",Presente,Subjuntivo," they will each be matched in different colours without the space highlighted - as expected.

selection_055

But if the keyword list contains ",Presente Subjuntivo," it wont be matched at all. I want them to match together, including the space, in the same colour.

Is what I'm seeing the expected behaviour?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.