Coder Social home page Coder Social logo

Comments (12)

dufferzafar avatar dufferzafar commented on May 25, 2024 1

Yes. I would love to help with the review, adding any new tests etc.

from smug.

ivaaaan avatar ivaaaan commented on May 25, 2024 1

Feel free to take the branch and proceed then. You can email me if you have any questions, I'll be happy to help you :)
I'll reopen the issue in this case.

from smug.

ivaaaan avatar ivaaaan commented on May 25, 2024

It seems like a good idea now, because smug has grown and probably will continue. I want to refactor tests a little bit, and then I'll try to start moving to urfave/cli/v2. I would appreciate any help. Perhaps move command by command

from smug.

mipmip avatar mipmip commented on May 25, 2024

I will find time to to some initial setup.

from smug.

dufferzafar avatar dufferzafar commented on May 25, 2024

@mipmip @ivaaaan I see that you were working on the clilib branch of this repository, but I don't see that branch anywhere now.

It wasn't merged either? Was it deleted by mistake?

I have some time on my hands and would love to work on smug in my free time. I have used tmuxp - https://github.com/tmux-python/tmuxp before which has a few features that smug doesn't. Like detecting currently running commands so they can be dumped with smug print.

from smug.

mipmip avatar mipmip commented on May 25, 2024

I don't know exactly what the current status is. It seems to be merged but the code seems to be missing

from smug.

dufferzafar avatar dufferzafar commented on May 25, 2024

Yeah, perhaps the branch was deleted from GitHub by mistake.

from smug.

ivaaaan avatar ivaaaan commented on May 25, 2024

I have been working on it for some time, but then abandoned it due to a lack of free time. If you want to add something new to smug, the best way is to create a new branch from the master.

from smug.

ivaaaan avatar ivaaaan commented on May 25, 2024

I'm closing this for now, because I don't think the big refactoring is coming soon. Thanks for the work you did @mipmip, but unfortunately I don't have the resources to finish it.

from smug.

mipmip avatar mipmip commented on May 25, 2024

I did spent a lot off time in the PR with the port. I would appreciate a another review. You already merged it once :). I know for sure I have the Diffs somewhere.

from smug.

mipmip avatar mipmip commented on May 25, 2024

Maybe @dufferzafar is interested in doing a review and a new PR?

from smug.

mipmip avatar mipmip commented on May 25, 2024

That's the open source spirit. @dufferzafar I found the feature branch here: https://github.com/mipmip/smug/tree/clilib. Feel free to ask me support on anything.

from smug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.