Request for `-L` option about smug

[ivaaaan]

Thanks for the suggestion. I don't have much time to work on it myself, but if you have a desire to work on this I will help you with anything. Feel free to reach out, my email is in the profile.

[ivaaaan]

@juboba have you started working on this? I got some free time and thinking about implementing this, or I can help you. Let me know if you have any progress

[dufferzafar]

@ivaaaan I was looking at the code, and I think this could be implemented in the Exec functions of commander.go where we would add the -L / -S socket details to cmd.Args before running a command:

smug/commander.go

Lines 28 to 57 in d053a9d

	func (c DefaultCommander) Exec(cmd *exec.Cmd) (string, error) {
	if c.logger != nil {
	c.logger.Println(strings.Join(cmd.Args, " "))
	}
	output, err := cmd.CombinedOutput()
	if err != nil {
	if c.logger != nil {
	c.logger.Println(err)
	}
	return "", &ShellError{strings.Join(cmd.Args, " "), err}
	}
	return strings.TrimSuffix(string(output), "\n"), nil
	}
	func (c DefaultCommander) ExecSilently(cmd *exec.Cmd) error {
	if c.logger != nil {
	c.logger.Println(strings.Join(cmd.Args, " "))
	}
	err := cmd.Run()
	if err != nil {
	if c.logger != nil {
	c.logger.Println(err)
	}
	return &ShellError{strings.Join(cmd.Args, " "), err}
	}
	return nil
	}

The -L / -S options could be passed to the commander instance from main.go:

smug/main.go

Line 81 in d053a9d

commander := DefaultCommander{logger}

Does that seem right?

[ivaaaan]

@dufferzafar sounds good. Feel free to create a PR, I'll take a look at it :)

[aswadsun]

Hi all, any progress on this feature?

Thanks,
Aswad