itspriddle / apnd

APND: Apple Push Notification Daemon sends Apple Push Notifications to iPhones

Hello there 👋

I'm Josh. I lead the Software Development team at A2 Hosting where we're building tools for WordPress web professionals. I write a bit over at josh.fail and I hack a bit here on GitHub.

apnd's Issues

Support for Apple Feedback

submitted invalid Notification

I am on an ubuntu machine with rails 2.3.8, and the apnd gem 0.1.6.

Notifications are sent beautifully when I see APND::Notification.create or use apnd-push -- i.e. one at a time. However, when I try to do this -

notification1 = APND::Notification.new(
:alert => 'Red Alert!',
:token => 'My Token,
:badge => 99
)

APND::Notification.open_upstream_socket do |sock|
sock.puts notification1
end

I see this in the log

[2011-02-17 05:29:56] Queue has 1 item
[2011-02-17 05:29:56] Sending notification for 'My Token'
[2011-02-17 05:36:46] 127.0.0.1:55122 opened connection
[2011-02-17 05:36:46] 127.0.0.1:55122 submitted invalid Notification
[2011-02-17 05:36:46] 127.0.0.1:55122 closed connection

and the notification doesn't go through.

Any help will be appreciated. Thanks.

Sending Push Notification to Invalid Device ID Breaks All Following Notifications

Here is the usual upstream socket code

socket = APND::Notification.open_upstream_socket do |sock|
      users.each do |user|
        notification = APND::Notification.new(
                              :token  => user.iphone_device_id,
                              :badge  => user.unread_count
                              )
        puts notification.token
        sock.puts(notification.to_bytes + "\n")
      end
 end

If one of the iphone device ids is invalid (user deleted the app etc.) notifications are skipped for all the following iphone device ids.

This happens even if I use this code

    users.each do |user|
      APND::Notification.create(
                          :token  => user.iphone_device_id,
                          :badge  => user.unread_count
                          )
    end

As always, your help will be really appreciated.

hard dependency on daemons 1.1.0

Just wondering if there a serious requirement to have a dependency on daemons version 1.1.0
My app uses thin which has defined the dependency on daemons to be >= 1.1.4
This makes bundler install apnd version 0.1.0 which is kinda old.

Test APN certificate password

Need to test APND::Daemon::AppleConnection with an APN certificate that requires a password.

open_upstream_socket multiple notifications bug

On using an open upstream socket to send multiple notifications as follows (using my own tokens)

# Initialize some notifications
notification1 = APND::Notification.new(
:alert  => 'Alert!',
:token  => 'fe15a27d5df3c34778defb1f4f3880265cc52c0c047682223be59fb68500a9a2',
:badge  => 1
)

notification2 = APND::Notification.new(
  :alert  => 'Red Alert!',
  :token  => '55711f0b3493d48abe829fe0f94f0829086335418e96d041ed62c5c7681904b4',
  :badge  => 99
)

# Send multiple notifications at once to avoid overhead in
# opening/closing the upstream socket connection each time
APND::Notification.open_upstream_socket do |sock|
 sock.write(notification1.to_bytes)
 sock.write(notification2.to_bytes)
end

The apnd log shows the notification being sent to the first device id twice

[2011-02-17 23:46:41] Queue has 2 items
[2011-02-17 23:46:42] Sending notification for  fe15a27d5df3c34778defb1f4f3880265cc52c0c047682223be59fb68500a9a2
[2011-02-17 23:46:42] Sending notification for    fe15a27d5df3c34778defb1f4f3880265cc52c0c047682223be59fb68500a9a2

I think this may be a bug but please let me know if there is something wrong with syntax. Thanks.

Tests for APND::Daemon

Not sure how to write tests for EventMachine yet...

N/A

N/A