itproto / ilsrep Goto Github PK

1. ConnectionThread it's supposed to be named PollHandler imho, handler is
in client-server terminology better name

2. Model* folder it's not good place for ConnectionThread. Model is
abstraction for "buiz. data" classes or domain objects, responsible for
internal state of application, something that we should save often to
database. For poll application I suppose - Poll, Choice, Pollsession. It's
real abstraction for users, ConnectionThread it's smth. internal. Sorry
maybe it's bad explanation, I'll discuss this topic on meeting

3. I would ask you to use sockets. As far I remember I've discussed that
(from my experience TcpListener it's simple dummy wrapper). Ok, it's my
internal requirement



===
Model is adopted by me from MVC pattern:
http://en.wikipedia.org/wiki/Model-view-controller

Please do it, because it's needed for simple evaluation. If you commit
without log message it means that changes are not important for anyone and
nothing ready done to check.

Add feature of editing session name in TabSender server web interface.

jspweb:
 - editor get's a lot of javascript errors if I use paging (mozilla)
- paging is not moved where I asked
- in IE doesn't works at all
- when I click edit poll button - CHOICES MUST BE HIDDEN!(as I asked)
- switching between editor and poll mode done other way as I asked (2 menu
items Client|Editor) and selected only current

Not tested, not ready still

Please check carefully ILS.PollClient.exe - what is missing for first
iteration 
- binding poll session to userName
- no READ_LINE. .bat closes window before I can read pollsession results . 

"/" is used as "webservice" for plugin and if access it with browser(w/o
any GET parameters) it redirects to /tabinfo.html, thats bad since if user
access http://tabsender.appspot.com/ it redirects to login with Google
Account and then redirects to "My Account" page, it should show "project
home page" with download links etc instead.

- fix redirection when accessing / via browser(w/o any GET parameters) from
/tabinfo.html to /home.html
- rename /home.html to /index.html.

1. High Priority After vlad commit I can't build anymore(see attached
screenshot). It seems that Working directory was set as absolute path(check
project properties and fix)

2.Please add to svn ignore content for debug-folder. End user will use
Release folder for test exe, I'll use debug folder to create my own exe and
don't commit it next time.

3. Check svn plugins for VS

What steps will reproduce the problem?
 - intall tomcat, copy jsp to root folder (follow readme.inf instructions)
Apache Software Foundation\Tomcat 6.0\webapps\ROOT


type Exception report

message

description The server encountered an internal error () that prevented it 
from fulfilling this request.

exception

org.apache.jasper.JasperException: Unable to compile class for JSP: 

An error occurred at line: 6 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Poll resolves to a 
package

An error occurred at line: 7 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Choice resolves to a 
package

An error occurred at line: 8 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Pollsession resolves 
to a package

An error occurred at line: 9 in the generated java file
Only a type can be imported. ilsrep.poll.server.db.SQLiteDBManager 
resolves to a package

An error occurred at line: 10 in the generated java file
Only a type can be imported. ilsrep.poll.server.db.DBManager resolves to a 
package

An error occurred at line: 11 in the generated java file
Only a type can be imported. ilsrep.poll.common.protocol.Pollsessionlist 
resolves to a package

An error occurred at line: 12 in the generated java file
Only a type can be imported. ilsrep.poll.common.protocol.Item resolves to 
a package

An error occurred at line: 13 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Poll resolves to a 
package

An error occurred at line: 14 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Choice resolves to a 
package

An error occurred at line: 15 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Pollsession resolves 
to a package

An error occurred at line: 16 in the generated java file
Only a type can be imported. ilsrep.poll.server.db.SQLiteDBManager 
resolves to a package

An error occurred at line: 17 in the generated java file
Only a type can be imported. ilsrep.poll.server.db.DBManager resolves to a 
package

An error occurred at line: 18 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Poll resolves to a 
package

An error occurred at line: 19 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Choice resolves to a 
package

An error occurred at line: 20 in the generated java file
Only a type can be imported. ilsrep.poll.common.model.Pollsession resolves 
to a package

An error occurred at line: 21 in the generated java file
Only a type can be imported. ilsrep.poll.server.db.SQLiteDBManager 
resolves to a package

An error occurred at line: 22 in the generated java file
Only a type can be imported. ilsrep.poll.common.protocol.Answers resolves 
to a package

An error occurred at line: 23 in the generated java file
Only a type can be imported. ilsrep.poll.common.protocol.AnswerItem 
resolves to a package

An error occurred at line: 24 in the generated java file
Only a type can be imported. ilsrep.poll.server.db.DBManager resolves to a 
package

An error occurred at line: 12 in the jsp file: /./links.jsp
Pollsessionlist cannot be resolved to a type
9: public String links() throws Exception{
10: String links="";
11: links="<ul>";
12: Pollsessionlist sessions;
13: DBManager db;try {
14: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
15: sessions=db.getPollsessionlist();


An error occurred at line: 13 in the jsp file: /./links.jsp
DBManager cannot be resolved to a type
10: String links="";
11: links="<ul>";
12: Pollsessionlist sessions;
13: DBManager db;try {
14: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
15: sessions=db.getPollsessionlist();
16:  for ( Item sess : sessions.getItems()) {


An error occurred at line: 14 in the jsp file: /./links.jsp
SQLiteDBManager cannot be resolved to a type
11: links="<ul>";
12: Pollsessionlist sessions;
13: DBManager db;try {
14: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
15: sessions=db.getPollsessionlist();
16:  for ( Item sess : sessions.getItems()) {
17: links+="<li><a href=\"./index.jsp?session="+sess.getId()
+"\">"+sess.getName()+"</a></li>\n";


An error occurred at line: 16 in the jsp file: /./links.jsp
Item cannot be resolved to a type
13: DBManager db;try {
14: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
15: sessions=db.getPollsessionlist();
16:  for ( Item sess : sessions.getItems()) {
17: links+="<li><a href=\"./index.jsp?session="+sess.getId()
+"\">"+sess.getName()+"</a></li>\n";
18: }
19: links+="<ul>";} catch (Exception e){links=e.getMessage();}


An error occurred at line: 14 in the jsp file: /./poll.jsp
Pollsession cannot be resolved to a type
11: String resultingOutput="<script type=\"text/javascript\" 
src=\"next.js\"></script>";
12: resultingOutput+="<form name=\"polls\" id=\"polls\" 
action=\"index.jsp\" method=\"get\">\n"+
13: "<input type='hidden' name='session' value='"+sessi+"' >";
14: Pollsession sess;
15: DBManager db;
16: int numberOfPolls=0;
17: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");


An error occurred at line: 15 in the jsp file: /./poll.jsp
DBManager cannot be resolved to a type
12: resultingOutput+="<form name=\"polls\" id=\"polls\" 
action=\"index.jsp\" method=\"get\">\n"+
13: "<input type='hidden' name='session' value='"+sessi+"' >";
14: Pollsession sess;
15: DBManager db;
16: int numberOfPolls=0;
17: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
18: sess=db.getPollsessionById(sessi);


An error occurred at line: 17 in the jsp file: /./poll.jsp
SQLiteDBManager cannot be resolved to a type
14: Pollsession sess;
15: DBManager db;
16: int numberOfPolls=0;
17: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
18: sess=db.getPollsessionById(sessi);
19: 
20: resultingOutput+="<h1>"+sess.getName()+"</h1>";


An error occurred at line: 21 in the jsp file: /./poll.jsp
Poll cannot be resolved to a type
18: sess=db.getPollsessionById(sessi);
19: 
20: resultingOutput+="<h1>"+sess.getName()+"</h1>";
21:  for (Poll currentPoll : sess.getPolls()) {
22: resultingOutput+="<div id="+Integer.toString(numberOfPolls)+" 
style=\"inner_poll\">";
23: resultingOutput+="<h2>"+currentPoll.getName()+"</h2>";
24: resultingOutput+="<h3>"+currentPoll.getDescription().getValue()
+"</h3>";


An error occurred at line: 25 in the jsp file: /./poll.jsp
Choice cannot be resolved to a type
22: resultingOutput+="<div id="+Integer.toString(numberOfPolls)+" 
style=\"inner_poll\">";
23: resultingOutput+="<h2>"+currentPoll.getName()+"</h2>";
24: resultingOutput+="<h3>"+currentPoll.getDescription().getValue()
+"</h3>";
25: for( Choice currentChoice : currentPoll.getChoices()){
26: resultingOutput+="<input type='radio' name='"+currentPoll.getName()+"' 
value='"+currentChoice.getName()+"'>"+currentChoice.getName()+"<br>";
27: }
28: if(currentPoll.getCustomEnabled().equals("true")){


An error occurred at line: 14 in the jsp file: /./submit.jsp
AnswerItem cannot be resolved to a type
11: <%!
12: public String getRes(ServletRequest request) throws Exception{
13: String res="<table border=\"1\">";
14:  List<AnswerItem> answers = new ArrayList<AnswerItem>();
15: Pollsession sess;
16: DBManager db;
17: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");


An error occurred at line: 14 in the jsp file: /./submit.jsp
AnswerItem cannot be resolved to a type
11: <%!
12: public String getRes(ServletRequest request) throws Exception{
13: String res="<table border=\"1\">";
14:  List<AnswerItem> answers = new ArrayList<AnswerItem>();
15: Pollsession sess;
16: DBManager db;
17: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");


An error occurred at line: 15 in the jsp file: /./submit.jsp
Pollsession cannot be resolved to a type
12: public String getRes(ServletRequest request) throws Exception{
13: String res="<table border=\"1\">";
14:  List<AnswerItem> answers = new ArrayList<AnswerItem>();
15: Pollsession sess;
16: DBManager db;
17: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
18: sess=db.getPollsessionById(request.getParameter("session"));


An error occurred at line: 16 in the jsp file: /./submit.jsp
DBManager cannot be resolved to a type
13: String res="<table border=\"1\">";
14:  List<AnswerItem> answers = new ArrayList<AnswerItem>();
15: Pollsession sess;
16: DBManager db;
17: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
18: sess=db.getPollsessionById(request.getParameter("session"));
19: if(sess.getTestMode().equals("true")){ res+="<tr><td colspan=2>Your 
selection</td><td>Result</td></tr>\n";


An error occurred at line: 17 in the jsp file: /./submit.jsp
SQLiteDBManager cannot be resolved to a type
14:  List<AnswerItem> answers = new ArrayList<AnswerItem>();
15: Pollsession sess;
16: DBManager db;
17: db = new SQLiteDBManager(null,getServletContext().getRealPath("/")
+"/pollserver.db");
18: sess=db.getPollsessionById(request.getParameter("session"));
19: if(sess.getTestMode().equals("true")){ res+="<tr><td colspan=2>Your 
selection</td><td>Result</td></tr>\n";
20: } else {


An error occurred at line: 26 in the jsp file: /./submit.jsp
Poll cannot be resolved to a type
23: 
24: float numberTotal=0;
25: float numberPassed=0;
26: for (Poll currentPoll : sess.getPolls()) {
27: numberTotal++;
28: AnswerItem answerItem = new AnswerItem();
29: if(request.getParameter(currentPoll.getName()).equals("custom_choice"))
{


An error occurred at line: 28 in the jsp file: /./submit.jsp
AnswerItem cannot be resolved to a type
25: float numberPassed=0;
26: for (Poll currentPoll : sess.getPolls()) {
27: numberTotal++;
28: AnswerItem answerItem = new AnswerItem();
29: if(request.getParameter(currentPoll.getName()).equals("custom_choice"))
{
30: answers.add(answerItem.setItem(Integer.parseInt(currentPoll.getId()), 
request.getParameter("custom"+currentPoll.getName())));
31: if(sess.getTestMode().equals("true")){ 


An error occurred at line: 28 in the jsp file: /./submit.jsp
AnswerItem cannot be resolved to a type
25: float numberPassed=0;
26: for (Poll currentPoll : sess.getPolls()) {
27: numberTotal++;
28: AnswerItem answerItem = new AnswerItem();
29: if(request.getParameter(currentPoll.getName()).equals("custom_choice"))
{
30: answers.add(answerItem.setItem(Integer.parseInt(currentPoll.getId()), 
request.getParameter("custom"+currentPoll.getName())));
31: if(sess.getTestMode().equals("true")){ 


An error occurred at line: 39 in the jsp file: /./submit.jsp
Choice cannot be resolved to a type
36: } else {
37: int selectionId=0;
38: String pass="";
39:               for (Choice currentChoice : currentPoll.getChoices()) {
40:                     if (currentChoice.getName().equals
(request.getParameter(currentPoll.getName()))) selectionId=Integer.parseInt
(currentChoice.getId());
41:                                   }
42: pass=(Integer.parseInt(currentPoll.getCorrectChoice())
==selectionId) ? "PASS" : "FAIL";


Stacktrace:
    org.apache.jasper.compiler.DefaultErrorHandler.javacError
(DefaultErrorHandler.java:92)
    org.apache.jasper.compiler.ErrorDispatcher.javacError
(ErrorDispatcher.java:330)
    org.apache.jasper.compiler.JDTCompiler.generateClass
(JDTCompiler.java:423)
    org.apache.jasper.compiler.Compiler.compile(Compiler.java:317)
    org.apache.jasper.compiler.Compiler.compile(Compiler.java:295)
    org.apache.jasper.compiler.Compiler.compile(Compiler.java:282)
    org.apache.jasper.JspCompilationContext.compile
(JspCompilationContext.java:586)
    org.apache.jasper.servlet.JspServletWrapper.service
(JspServletWrapper.java:317)
    org.apache.jasper.servlet.JspServlet.serviceJspFile
(JspServlet.java:342)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:717)

Please prepare code according to CC2#11

404 status on /favicon.ico (as reported in TabSender server logs)

This icon should be added from plugin's icon for Firefox menus.

 We discussed this issue, need we this "saver" again or you forget about? ( 

Coding fail in TabSender webpage.

Screenshot attached.

TabSender Firefox Plugin is not compatible with Firefox 3.5; at least >=
3.5.2, as shown on attached screenshot.

What steps will reproduce the problem?
- select pollsession
- click go, go, go
- getting error on resultpage


What is the expected output? What do you see instead?
TTP Status 500 -

type Exception report

message

description The server encountered an internal error () that prevented it
from fulfilling this request.

exception

org.apache.jasper.JasperException: java.lang.NullPointerException
    org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:522)
    org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:416)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
root cause

java.lang.NullPointerException
    org.apache.jsp.index_jsp.getRes(index_jsp.java:112)
    org.apache.jsp.index_jsp._jspService(index_jsp.java:274)
    org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
note The full stack trace of the root cause is available in the Apache
Tomcat/6.0.18 logs.

URGENT
- please add readme file how to test website. MUST be simple steps, with
minimum software installed

Just've try to test last revision
http://code.google.com/p/ilsrep/source/detail?r=159
1.I suppose that I should run *.bat files from /scripts folder now?
If 'yes' then add readme.txt in root-dir, to get end-user know how to run
applications(it's small issue)

2. Could you stop output window from closing? (on error for example)

3. Critical issue. It doesn't work. Please fix asap. I've in my console:

>..ilsrep\poll\jteam\scripts>java -
cp poll.jar;lib\xpilotpanel-lib.jar;lib\log4j-1.2.15.jar
ilsrep.poll.server.Poll
Server configuration.xml
Exception in thread "main" java.lang.NoClassDefFoundError:
ilsrep/poll/server/Po
llServer
Caused by: java.lang.ClassNotFoundException: ilsrep.poll.server.PollServer
        at java.net.URLClassLoader$1.run(Unknown Source)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(Unknown Source)
        at java.lang.ClassLoader.loadClass(Unknown Source)
        at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
        at java.lang.ClassLoader.loadClass(Unknown Source)
        at java.lang.ClassLoader.loadClassInternal(Unknown Source)

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.