Coder Social home page Coder Social logo

dinar's People

Contributors

trojikman avatar yelizariev avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

dinar's Issues

Preview JOB: fix work with artifact

The artifact may absent at the moment of execution script: either because it's not ready yet or because it's not created in specific build

Scheduled image rebuilding works only for default branch

The posible workaround could be making a push event to any file of .DINAR/ folder. It can be done directly in specific branch of a repo OR it can be done in forked DINAR and propagated by fork2repos script

Not sure it should be automated. I'd prefer just document this workaround

flake8 error

https://github.com/itpp-labs/sync-addons/actions/runs/3219926194/jobs/5265950297

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/lib/python3.7/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/lib/python3.7/site-packages/flake8/main/application.py", line 363, in run
    self._run(argv)
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/lib/python3.7/site-packages/flake8/main/application.py", line 350, in _run
    self.initialize(argv)
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/lib/python3.7/site-packages/flake8/main/application.py", line 330, in initialize
    self.find_plugins(config_finder)
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/lib/python3.7/site-packages/flake8/main/application.py", line 153, in find_plugins
    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/lib/python3.7/site-packages/flake8/plugins/manager.py", line 357, in __init__
    self.namespace, local_plugins=local_plugins
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/lib/python3.7/site-packages/flake8/plugins/manager.py", line 238, in __init__
    self._load_entrypoint_plugins()
  File "/home/runner/.cache/pre-commit/repoazk14xe_/py_env-python3/lib/python3.7/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
AttributeError: 'EntryPoints' object has no attribute 'get'

Don't run image building in PR's branches

In private repositories pull requests should not be forked. That is a developer creates a temporary branch for this. Such a branch doesn't need own docker images. So, we need to disable the workflow for such cases.

On the other hand, there is a case when new temporary branch is created to send PRs there. In that case we need the docker images.

So, the specification could be as following:

make images only for main branches (10.0, 11.0, etc.) and development branches (10.0-dev-<some-name>, 11.0-dev-<another-name>

problem with external_dependencies checking

pre-commit работает неккорректно, Похоже пайлинт даёт ложно позитивный результат
в манифесте есть требования, но пишет что не может найти

************* Module sync_telegram.models.sync_project
sync_telegram/models/sync_project.py:11: [W7936(missing-manifest-dependency), ] Missing external dependency "telegram" from manifest. More info: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#external-dependencies

Properly apply license

It's basically adding the following header to every file

# Copyright 2020 IT-Projects Labs
# 
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# 
#     http://www.apache.org/licenses/LICENSE-2.0
# 
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"docker save" works slowly

It takes about 4 minutes to execute "docker save" and unpack with pipe.

We need to try using "docker export" before and after modules installation. Then diff can be extracted from two snapshots

precommit in Quick Review doesn't work

 pre-commit run --show-diff-on-failure --color=always --show-diff-on-failure --files $(git diff --name-only --no-ext-diff -z 14.0..HEAD)

From https://github.com/itpp-labs/pos-addons
 * branch            14.0       -> FETCH_HEAD
 * [new branch]      14.0       -> origin/14.0
fatal: ambiguous argument '14.0..HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
autoflake..........................................

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.