ithim / ict Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 4.0 927.68 MB

Impacts of Cycling Tool

Home Page: http://pct.bike/ICT/

License: GNU Affero General Public License v3.0

R 69.86% HTML 30.14%

ict's Introduction

ITHIM: Integrated Transport and Health Impacts Model

Welcome to the repository for the R package ITHIM. Please also visit the package tutorial page.

Quick Start

if (!require(devtools))
  install.packages("devtools")
library("devtools")
devtools::install_github("ITHIM/ITHIM", ref="ITHIM-R")
#devtools::install("~/ITHIM/")
library("ITHIM")
example("ITHIM")

ict's People

Contributors

Stargazers

Watchers

Forkers

syounkin vargovargo usr110 ofurhe

ict's Issues

is the "health" tab graph title correct?

I think on the Health tab, the title is not correct always to say "for the English population". I think it should instead say "for the selected Region"

In "Total population" charts details regarding filters shouldn't be presented in the subtitles

Only "Total size:".

replacing HSE with APS

replacing calculation of non travel METs by Health Survey for England with Active People survey.

Waiting for M MET values to be assigned to activities by Kate.
This should be done some time in 2nd half of Sept.

Add progress bar when users switch regions

From @AnnaGoodman1

if there is some way to let people know that it is still working just working slowly? E.g. some sort of “I'm thinking” symbol from the computer (hourglass or wheel or whatever), or some message somewhere? Otherwise I think other people may, like me, just think it is working

running very slow

it was going quite fast but seems to have slowed right down

feast of England, this seems to be a noticeable difference between "baseline" and "5%", but the baseline cycling percent is 4.9%,so I'm not sure why this difference is visible? elsewhere, we don't give the option "5%" forEast of England, so I wondered if there was a bbug here

text explanations when graphs are missing

in images like the one shown here, the graph is not shown, presumably because I chose a very small subgroup. If possible, it would be nice if an error message could appear in the place with the graph would be usually to explain why the graph is not visible. ee.g. saying "Graph not displayws, as based on a subgroup of <X people/trips (populated using the National Travel Survey, 2004-2014)"

In all tabs top chart should present "Scenario", while bottom "Baseline"

pa summary

change heading to indicate this is travel pa only

Subtitles for tabs

For a region, once an alternate region is selected, it's title should be represented in Scenario (Total Population). Also the order of the bars should be:

Selected region
Alternate region

opposite of what it is at the moment.

5% of population cyclists

this scenario is giving some odd results.
In particular equity does not improve the values (e.g. mode share cycling) for older women. Please check and see why this is happening

travel times wrong for cars for most regions

@TSzDefr
from what I can see hapening far too many of the faster trips are coming from cars, compared with the national level results. Ive mainly been looking at north west but other regions seem to have the same problem

Round % of cyclists in the population to integer (used in calculations in directProbs.R)

co2 wrong for regions

@TSzDefr @audev
Doc2.docx
the co2 emissions seem to go up with more cycling

Miles Cycled: info about used denominator in subtitle/title

No trips data is missing [Car Access] variable

In the No trips data dataset read here:

https://github.com/ITHIM/ICT-Model/blob/master/0_topflow2-2012.R#L74

the Car Access variable is empty, so it can't produce correct aggregates in:

https://github.com/ITHIM/ICT-Model/blob/master/3_CBM2_Aggregates-2012.R

Top plot should display Total Population in its title when no sub-population is selected

Only working in Journey Time tab. All other tabs should have the same title structure.

Fonts (style) unification

No trips data being wrongly added in aggregates

E.g in lines
https://github.com/ITHIM/ICT-Model/blob/master/3_CBM2_Aggregates-2012.R#L123

and

https://github.com/ITHIM/ICT-Model/blob/master/3_CBM2_Aggregates-2012.R#L127

journey time

make slower/faster trips default option

miles Cycled wrong at regional level

milesCycled tab seems to produce correct nos. for England (to be checked) but wrong at the regional level, since the absolute nos. of cyclists for some ranges (0-2km, 2-5 km) go down.

Remove 'total population' as a radio button's option from Miles Cycled tab

Recheck health values for 5% scenario for England

For women and older men in some cases the YLLs are zero.

miles cycled summary

either make this miles cycled per capita (not car miles cycled) or remove it

In all tabs top chart should present "Sub-population", while bottom "Total population"

Just like it is in "Miles Cycled".

Update ICT text

ict edits2.docx
170321_ICTedits.docx

Car Miles: verification is needed to check if labels/subtitles are ok

figures no longer have details of scenario on them

@TSzDefr
for mode share- when you download the image the details on which scenario has been selected are not available, compare this with say physical activity- here the details of the scenario are available.

adding the missing tabs

the tabs available for version 1 need to be added to version 2

Mode Share- done
Journey Time- to be added
Miles Cycled- to be added
Physical Activity- done
Health- done
Car Miles- to be added
CO2-done
Summary-done
About-done

pa tab title

There is currently a mistake on thePA tab for the percent meeting guidelines – the title is not correct. Instead of saying 'Marginal MET hours' it should say '% meeting activity guidelines'

if region is already above a given % cyclists & showing baseline

We need to see % cyclists at baseline for England and each region

When a region has > 5% cyclists at baseline e.g. east of england then for scenario of 5% (and 10% if appropriate) we should have those lower options greyed out

Number of deaths and YLL reductions should be rounded to two decimal places

trip purpose

if we could split up mode share by trip purpose that would be very nice

Verification if exported images (with figures) are ok

Check if figures with the longest possible subtitles with the longest possible name of the region (+ alternative region) export correctly

Add Tomek to about page!

We should add Tomek to the list of contributors on the about page :)

% meeting guidelines

make this default setting

Dependencies

I see your using dplyr and plyr https://github.com/ITHIM/ICT/blob/master/app/setup.R#L6-L7
Could you limit the use to just dplyr (or just plyr)? I've had lots of issues with R pacakges so for shiny apps on the server would like to limit them to the bare minimum.

ggplot2 is a dependency from Shiny so that shouldn't be needed.

I'd really like to avoid using devtools as these versions can change rapidly, there is an issue to publish rCharts on CRAN ramnathv/rCharts#340 that it is worth keeping 👀 on

Health: wrong data for some regions for 5% scenarios

direct probability method

confirming if the two different ways of calculating the direct probabilty give the same result

suggested wording clarification

I like the new feature of telling people the baseline cycling, e.g. "Baseline Cycling (%): 3.8 " for England. However could this be clarified as to what it actually means, I wasn't sure. Do you mean "Potential cyclists at baseline (%)", or "% of population cycling weekly at baseline", or "% trip cycled at baseline" or something else? I would suggest that the percentage of potential cyclists is the most relevant thing, since that is what we allow people to select?