israel025 / mongo_express Goto Github PK

Same issue as #1

In the following code for updating a student, the update argument which is an object could possibly be unsetting an already set field to undefined. Consider an instance where req.body.gender does not exist in the request body but the student already has a gender set, going by your code the student's gender field will be set to undefined because it does not exist in the request body. A better way to write the update argument is by simply sending the request body as the update argument. E.g

const updatedStudent = await StudentModel.findOneAndUpdate(
      { student_id: req.params.student_id },
      req.body,
      { new: true }
);

By doing that you're only sending the fields that are present in the request body as updates without tampering with fields that have already been set but may not exist in the request body. So in the instance where req.body is {"first_name": "Frank", "last_name": "Sinatra"} only the first_name and last_name fields will be sent as update arguments.