ishaaanvyas / pe Goto Github PK

I get no response from the application when I enter such a long number, as a user I'm quite confused as to what is happening as there has been no acknowledgement from the application.

Multiple arrows are showing an association between FinanceParser and Finance. Since there's already an arrow showing an association why add one more?.

Since both Employee and EmployeeList are part of the class diagram, could just add an association between them instead of adding employeeList as an attribute in EmployeeList

First I added an employee

Then when I typed in remove-employee/0 due to an error the program exited (already created a separate issue for this error)

Now entering the application again, the employee I had added before is missing.

(This occurs with all other commands as well, didn't want to create a separate issue for all those)

Pretty sure "1" is an invalid phone number in all countries.

I can completely skip the name for the employee and it still registers it as an employee without a name. This confuses me a lot as a user.

Here the first line says there is an error in writing the data perhaps? but the 2nd line says storage saved successfully. So Im confused, was it successful or not?

If the method is only being called inside the opt block then the return should be inside the opt block as well

As a user who can type fast I still would not be able to use this application faster than using point and click on GUI, this might cause the target users to not be willing to use this app. Perhaps instead of having to type add-employee , it could have been shortened to add-e

Trying to remove the 0th index causes error

Could have made it much simpler and easier to understand by removing methods/attributes that were not necessary to the understanding of the class diagram. (Pretty sure all the print methods are not necessary to understand the relationship between the classes).

Here also this is very complicated:

No details provided by bug reporter.

Since the sequence diagram here shows that all methods being called here are class-level methods (cause of the <<class>>)

I would expect the class diagram to show all methods as class-level methods also

here financeList:ArrayList<Finance> is shown as an attribute but there is also an association between FinanceList and Finance

Occurs again here:

Let's say I own a restaurant that is trying out new things to hopefully get more customers and I wanna name one of the dishes as specia| cause it looks cool, however when I run the application again after doing that it does not even begin.

(The same thing occurs for all other commands such as add-employee and add-ingredient as well, however it wouldn't make sense to have a "|" character in that name.)

I think the arrows are not supposed to meet each other

Hyperlinks for Dish, Ingredient and so on could have been added for easier navigability. (There's a hyperlink for Employee but not for the rest?)

what methods are being called here?