ir33k / tb-keycast Goto Github PK

Your version of keycast looks nice at the tab-line, except that I do not really want to use the rest of the tab-line.

So, I have customized the tab-line format as the following:

(setq-default tab-bar-format nil)
  (set-face-attribute 'tab-bar nil
                      :inherit 'default
                      :underline (color-lighten-name (face-foreground 'default) 80))

However, it now feels natural to move the keycast indicator to the left. It would be useful to add such customization.

It looks like width used to calculate position of tb-keycast status is taken from current buffer window width instead of frame width.

To reproduce simple enable tb-keycast-mode and create split with C-x 3.

Seeing the last command is indeed nice, but easy to miss at times. It would be useful to add an option to display recent commands in a side window slot in Emacs.

Hi @ir33k!

Notice this:

Emacs version 8.1 or higher is required.

I discover that all calculations of position and width used to align status string to the right and avoid wrapping are incorrect when tab-bar have different font than buffer.

Its because to calculate width of string in pixels string-pixel-width function is used. It works by inserting string to temporary buffer and takes measurements there. If your buffer font is for example monospace but tab-bar font use proportional font it will return wrong value.

I believe that to fix this all we need is to apply font used in tab-bar to string before string-pixel-width function is used.

When I run a lambda function from inside helm, I can reliably "freeze" the keycast indicator. It happens because tb-keycast--update throws and error and Emacs automatically removes it from command hooks.

The error is the following

(wrong-type-argument symbolp (lambda nil (interactive) (helm-select-nth-action 1)))

Current faces setup can be used to customize foreground color and font look but modifying background color will result in gap between parts of status string.

I just tried to increase the tab-bar font height:

(set-face-attribute 'tab-bar nil
                      :inherit 'default
                      :underline (color-lighten-name (face-foreground 'default) 80)
                      :height 2.0)

The result is ugly tab-bar wrapping to second line.

The problem appears to be not in tb-keycast itself, but rather in tab-bar-format-align-right. I guess it should be reported to Emacs upstream.

It is not currently possible to distinguish between commands called with and without prefix arguments (numeric or C-u). Yet, this information is important to understand what is happening - command behaviour might be significantly changed depending on the prefix argument.

It would be nice to display the non-nil prefix argument in addition to the nominal key sequence.