iph0 / redis-clusterrider Goto Github PK

Hello,

We are using Redis library for our DEV environment and ClusterRider as a production solution with just simple inheritance. And I found issue in the following code:

    my @fields = qw(data cryptor gzip);
    my %data;
    @data{@fields} = $self->{redis}->hmget($key, @fields);

and on dev environment $self->{redis} is instance of Redis class and in production it's Redis::ClusterRider.

But because of the following code:

$reply = $node->$cmd_method( @{$args} );

We are having bug, because there is force to use scalar context, and Redis returns array reference instead of list.

I reworked our code to use scalar context for both libraries, but it would be great if Redis::ClusterRider also can account wantarray logic.

Running the code with non-clustered Redis leads to exception:

# perl -MRedis::ClusterRider -e 'Redis::ClusterRider->new(startup_nodes=>["127.0.0.1:6379"])'
[cluster_info] ERR This instance has cluster support disabled,  at /usr/local/share/perl/5.28.1/Redis.pm line 275.

From my perspective it would be great if Redis.pm was transparently used instead.

@iph0, I could implement such a feature in the future, if its OK from your side.