Comments (16)
This passes fine for me with following Mesa branch (near master):
https://github.com/tpalli/external-mesa/tree/rebase_20190930
from external-mesa.
Hi @tpalli, did you also upgrade minigbm to latest?
https://github.com/intel/minigbm
from external-mesa.
Maybe not (?) I'm just using what comes with 'repo sync'. Will try later if I missed some commits.
from external-mesa.
OK yeah, now it fails due to incomplete framebuffer. Will investigate.
from external-mesa.
Yeah, in this case for some reason the internalformat is unsized GL_RGBA while spec only allows explicitly sized internal format. Will need to see why this is happening.
from external-mesa.
Here we add render usage for RGBA1010102 as some other cases ask for render usage.
https://github.com/intel/minigbm/pull/88/files#diff-44dcf7ec91657ef4bd641a0d29fa81b5R111
Not sure if it is reasonable to add RGBA1010102 to renderable format.
from external-mesa.
IMO it is OK to add RGBA1010102 as renderable format, we do support this and there are many other tests rendering to this format with Mesa. This seems to go via glEGLImageTargetTexture2DOES path, maybe something is going wrong already there, we should check how the texture bound to that EGLImage was generated.
from external-mesa.
This fixes the issue:
https://gitlab.freedesktop.org/tpalli/mesa/commit/86259b7936877c7a9c6b4ea216449615ac078068
However, it's not quite clear to me why the original internalformat is GL_RGBA and if that is actually a bug in the test itself. Will need to investigate more.
from external-mesa.
Thanks @tpalli! Could you also help to create one PR on github? We may include the PR, and create one EB, and then have one round of full test.
I also have some debugging work for this issue before. And found there is some issue that RBGA1010102 is removed from renderable format. When I added it back, issue also could be gone.
I reverted following commit d2b60e4 in mesa, case could pass and no regression from dEQP and other cts modules. Not sure if this is right.
commit d2b60e433e50032e398fb92181f22a78601a5538
Author: Nicolai Hähnle <[email protected]>
Date: Wed Sep 27 15:25:10 2017 +0200
mesa/main: R10G10B10_(A2) formats are not color renderable in ES
The EXT_texture_type_2_10_10_10_REV (ES only) states the following issue:
"1. Should textures specified with this type be renderable?
UNRESOLVED: No. A separate extension could provide this functionality."
This partially fixes
dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.{rgb,rgba}_unsigned_int_2_10_10_10_rev
Reviewed-by: Marek Olšák <[email protected]>
from external-mesa.
Yes I noticed this but Nicolai's commit looks good to me. GLES does not allow rendering to texture with unsized format (such as GL_RGBA), it should allow only GL_RGB10_A2 so that should be valid restriction. I will need to check if my patch is indeed correct or if there is a bug in the test. I believe that meanwhile it should be safe to use my patch as a WA, I'm currently running it through Mesa CI and will report if there are any regressions from it.
from external-mesa.
ok, got it, thanks a lot! Once there is no regression, please help create one PR, we would trigger one round of full CTS GFX test. :)
from external-mesa.
So ... I'm still a bit confused with how Celadon trees work. I keep using 'project-celadon' but now and then some trees should be used from 'intel' instead. For which tree should I send this PR for?
from external-mesa.
I sent here MR against Mesa master:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2305
If my fix is not correct, we probably hear it from there :)
from external-mesa.
@tpalli, thanks a lot for the MR. If possible, please help send this PR to 'intel'.
'project-celadon' is some like "release" branch. We need confirm the quality of whole image.
'intel' is our internal developing branch. We will rebase new mesa version to 'intel', and then fix Android specific issues. Once it is stable. We will push 'intel' to 'project-celadon'(most of time, we need pass CTS GFX test and sanity test). Currently, mesa on 'project-celadon' is 19.0.6. mesa version of 'intel' is 19.1.6. Now, we are working to fix all CTS issues based on 19.1.6. Once all are fixed, we will push 19.1.6 to 'project-celadon'. :)
We could push the PR to 'intel' and build EB on gfx build bot, the difference between 'intel' and 'project-celadon' is four gfx repos: minigbm, mesa, libdrm and hwc. The new changes is on 'intel'.
Hope this could help on the confusion, if any other confusion, please help point out, thanks a lot!
from external-mesa.
Thanks @renchenglei, I've created a PR here:
#136
from external-mesa.
@tpalli, ok! Thanks a lot!
from external-mesa.
Related Issues (20)
- Help backport upstream patch to fix SKQP issue HOT 15
- Help backport upstream patch to fix WebGL regression with latest Chrome(70.0.3538.80) HOT 5
- Crashes in dEQP-VK.spirv_assembly.instruction.compute* HOT 3
- [Mesa19.2.1] dEQP-GLES31.functional.ssbo.layout.random.all_per_block_buffers#18 test fail HOT 2
- [Mesa19.1.2]dEQP-VK.binding_model.descriptorset_random.sets8.unifindexed.ubolimitlow.sbolimithigh.imglimithigh.iublimitlow.frag#0 test fail
- Add FP16 support on Android HOT 9
- [mesa 19.1.6]dEQP-VK.binding_model.descriptorset_random.sets8.* failed due to timeout
- [mesa 19.1.6]dEQP-VK.ssbo.layout.random.16bit.all_shared_buffer#40 failed due to timeout HOT 5
- [mesa 19.1.6]3 vulkan scalar cases failed due to timeout HOT 2
- [mesa 19.1.6]dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.* failed due to timeout HOT 2
- [mesa 19.1.6]dEQP-EGL.functional.sharing.gles2.multithread.random.* failed HOT 1
- [mesa 19.1.6]dEQP-VK.api.external.memory.android_hardware_buffer.* failed due to crash HOT 11
- [ww29] dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer have 3 tests failed on android HOT 13
- [ww33] dEQP-VK.api.info.device#extensions failed on android HOT 10
- [ww33]dEQP-VK.ubo.random.all_shared_buffer#48 failed on android HOT 8
- [ww33]dEQP-VK.wsi.android.display_timing have 4 tets failed on android HOT 3
- [ww33] dEQP-VK.wsi.android.swapchain have 2 tests failed on android HOT 3
- [ww33] dEQP-VK.wsi.android.incremental_present have 8 tests failed on android. HOT 10
- [ww33] dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 timeout on x86_64 abl HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from external-mesa.