Comments (9)
I can help with the backport but I'll want to have the Android platform code in place before we push to master. Can you open an upstream PR? If it helps, I can make a topic branch available for you with the current fp16 code backported to external-mesa master.
from external-mesa.
I can help with the backport but I'll want to have the Android platform code in place before we push to master. Can you open an upstream PR? If it helps, I can make a topic branch available for you with the current fp16 code backported to external-mesa master.
Do you mean Android 10 code? Now, we could download latest Celadon with Android 10, :)
from external-mesa.
There are some (hopefully) minor changes needed in the Android driver for EGL in order to make FP16 available to Android apps, the patch series that we landed upstream only covers GBM platform. @renchenglei I was under the impression that you had started that work, is that true?
btw, can you list the relevant CTS tests here?
from external-mesa.
@strassek, yes, in fact, we have back ported your FP16 patches on GP 2.1 based on mesa 19.0.6. And have passed all related CTS test. Besides your FP16 patch set, we also need enable FP16 on Android platform(https://lists.freedesktop.org/archives/mesa-dev/2019-August/222379.html).
Here are some cases related to FP16:
CtsDeqpTestCases dEQP-VK.api.external.memory.android_hardware_buffer.image_formats#r16g16b16a16_sfloat(this may failed on x86 platform)
CtsDeqpTestCases dEQP-VK.wsi.android.incremental_present.scale_none.mailbox.*
CtsGraphicsTestCases android.graphics.cts.ImageDecoderTest#testTargetColorSpace
CtsGraphicsTestCases android.graphics.cts.BitmapColorSpaceTest#test16bitHardware
CtsNativeHardwareTestCases "here you could run the whole module"
from external-mesa.
Interesting, I didn't see that patch. I guess that satisfies some checks to see if the HAL format is mapped to something, but I can tell you it doesn't actually expose the visual or enable fp16 in the dri driver. In other words, apps aren't going to find an fp16 egl config.
I used these tests in the past to check if a fp16 config can be found, without support in place they will pass as NotSupported:
dEQP-EGL.functional.wide_color.fp16
dEQP-EGL.functional.wide_color.window_fp16_default_colorspace
from external-mesa.
@renchenglei Was something like this needed in your GP 2.1 backport?
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index f968cd7af27..82a0bed5c62 100644
--- a/src/egl/drivers/dri2/egl_dri2.c
+++ b/src/egl/drivers/dri2/egl_dri2.c
@@ -65,6 +65,7 @@
#include "util/u_atomic.h"
#include "util/u_vector.h"
#include "mapi/glapi/glapi.h"
+#include "util/bitscan.h"
/* Additional definitions not yet in the drm_fourcc.h.
*/
Submitted as https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1973
from external-mesa.
@strassek, for the two fp16 test, I tried on Android, and it does pass with "Not Supported". You are right, maybe we need some other more config to enable FP16?
For the ffs issue, we didn't encounter on GP 2.1.
from external-mesa.
We need the Android equivalent of what Ajax did for Wayland and Surfaceless:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1942
And then we need to switch it on by setting "allow_fp16_configs" to "true" in driconf.
from external-mesa.
I've backported the fp16 patches and pushed to master. I'll leave this issue open until we add in the Android surface support.
from external-mesa.
Related Issues (20)
- Help backport upstream patch to fix SKQP issue HOT 15
- Help backport upstream patch to fix WebGL regression with latest Chrome(70.0.3538.80) HOT 5
- Crashes in dEQP-VK.spirv_assembly.instruction.compute* HOT 3
- [Mesa19.2.1] dEQP-GLES31.functional.ssbo.layout.random.all_per_block_buffers#18 test fail HOT 2
- [Mesa19.1.2]dEQP-VK.binding_model.descriptorset_random.sets8.unifindexed.ubolimitlow.sbolimithigh.imglimithigh.iublimitlow.frag#0 test fail
- [mesa 19.1.6]dEQP-VK.binding_model.descriptorset_random.sets8.* failed due to timeout
- [mesa 19.1.6]dEQP-VK.ssbo.layout.random.16bit.all_shared_buffer#40 failed due to timeout HOT 5
- [mesa 19.1.6]3 vulkan scalar cases failed due to timeout HOT 2
- [mesa 19.1.6]dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.* failed due to timeout HOT 2
- [mesa 19.1.6]dEQP-EGL.functional.sharing.gles2.multithread.random.* failed HOT 1
- [mesa 19.1.6]dEQP-VK.api.external.memory.android_hardware_buffer.* failed due to crash HOT 11
- [mesa 19.1.6]android.hardware.nativehardware.cts.AHardwareBufferNativeTests failed HOT 16
- [ww29] dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer have 3 tests failed on android HOT 13
- [ww33] dEQP-VK.api.info.device#extensions failed on android HOT 10
- [ww33]dEQP-VK.ubo.random.all_shared_buffer#48 failed on android HOT 8
- [ww33]dEQP-VK.wsi.android.display_timing have 4 tets failed on android HOT 3
- [ww33] dEQP-VK.wsi.android.swapchain have 2 tests failed on android HOT 3
- [ww33] dEQP-VK.wsi.android.incremental_present have 8 tests failed on android. HOT 10
- [ww33] dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 timeout on x86_64 abl HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from external-mesa.