integrations / html-to-mrkdwn Goto Github PK

Tables are currently converted to their markdown equivalent and then rendered as plain text. That is very painful on the eyes.

Version 11.12.0 of jsdom was just published.

This version is covered by your current version range and after updating it in your project the build failed.

jsdom is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Unfortunately, I don't think Slack supports images in message formatting.

For example, in this issue mozilla/tls-observatory#298

Notice that in the issue, there's a link with the text Upcoming_Distrust_Actions wiki but in the slack message it's Upcoming\_Distrust\_Actions wiki

GitHub allows you to use <details> and <summary> tags to collapse content that is noisy or may not always be relevant. This

If the source HTML has square brackets (in this case, [foo] in an issue title), the square brackets appear escaped in the resulting Markdown:

the real url is git+https://github.com/integrations/html-to-mrkdwn.git
The links back to repository on npmjs don't work https://www.npmjs.com/package/html-to-mrkdwn

If you paste a link to code on GitHub in a comment, the code snippet gets rendered as a table. This should probably just be translated into a link to the file and a code snippet in mrkdwn.

I am using this package to convert rendered Jira comment HTML, and their code blocks look something like:

<div class="code panel" style="border-width: 1px;">
    <div class="codeContent panelContent">
        <pre class="code-sql">...</pre>
    </div>
</div>

Could we generalize the highlightedCodeBlock rule to support this DOM structure? Should all <pre> tags be converted to triple backtick blocks?

These could be translated into real unicode characters like ☐ and ☑︎.

This is what happens when you post a link to for example an image file:

Not sure if there is a way we can handle this in html-to-mrkdwn or if we should detect for example image file extensions in integrations/slack and just not send them to html-to-mrkdwn

When creating a Release on GitHub with two headers in the description like so:

## Released

### Changed

the /integrations/slack integration created a slack post like this:

My guess is that the markdown is being converted to an <h2> and <h3> with no space between them, and that html-to-mrkdwn is not going out of its way to add a newline back.

Because the <h1> through <h6> tags default to display: block, they naturally stack when viewed in a browser. As such, the expected behavior should be that headers – once converted – always begin and end with a newline.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Leading js here should be stripped out of code fence:

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

When Slack truncates messages in the middle of a code block, it just shows six backticks:

When you expand the message it renders fine:

I'm not sure there is much we can do about this, but wanted to open an issue to at least report it.