instructure / ic-tabs Goto Github PK

View Code? Open in Web Editor NEW

65.0 65.0 12.0 2 MB

License: MIT License

JavaScript 98.73% CSS 1.27%

ic-tabs's People

Contributors

Stargazers

Watchers

Forkers

ef4 rtablada atsjj mirego saygun quaertym samheuck jrhe niedfelj greyhwndz sylwiaeb isabella232

ic-tabs's Issues

figure out why travis-ci isn't running any tests

The output says "0 of 0", locally there are 7 tests.

Ember 1.8.0 compatibility

With the release of ember 1.8.0 the tab panels don't seem to be rendering anymore. There are no errors being displayed so I don't quite know what is causing the issue.

http://emberjs.jsbin.com/yiqefa/3 is a jsbin running 1.8.0 with the example ic-tabs

I would be more than happy to try and fix the issue if I knew what was going wrong.

Error using ember v1.9.1

I get the following error when I try to use ic-tabs with ember 1.9.1:

Uncaught Error: Unknown template object: function

test/fix support for dynamic tabs

if tabs and panels are created in an {{#each}}, we need to do some teardown work (remove things from tabList.tabs and tabPanels), and make sure to select a new tab when the current tab is destroyed.

Developing

I wanted to open up a PR to bump ic-styled to 0.2.0.

I tried cloning the repo + running npm install, and got this error:

npm ERR! Error: version not found: [email protected]
npm ERR!     at ~/.nvm/v0.10.31/lib/node_modules/npm/lib/cache/add-named.js:125:12
npm ERR!     at saved (~/.nvm/v0.10.31/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:167:7)
npm ERR!     at Object.oncomplete (fs.js:107:15)
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! System Darwin 13.4.0
npm ERR! command "~/.nvm/v0.10.31/bin/node" "/Users/SamSelikoff/.nvm/v0.10.31/bin/npm" "install" "[email protected]"
npm ERR! cwd ~/Projects/ic-tabs
npm ERR! node -v v0.10.31
npm ERR! npm -v 1.4.23
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     ~/Projects/ic-tabs/npm-debug.log
npm ERR! not ok code 0

Any tips on how to get this working so I can help out w/development?

Passing Index to #ic-tab does not initialize properly

When passing a custom index to ic-tab components, the tabs list does not initialize as expected.
Clicking on a tab does update the property to the custom index, but no tab is selected by default.

Code modification of example:

  {{#ic-tabs selected-index=food}}
    {{#ic-tab-list}}
      {{#ic-tab index="hamburger"}}Hamburger{{/ic-tab}}
      {{#ic-tab index="noodles"}}Noodles{{/ic-tab}}
      {{#ic-tab index="toast"}}Toast{{/ic-tab}}
    {{/ic-tab-list}}

    {{#ic-tab-panel}}
      <h2>Hamburger</h2>
      <p>
        Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod
        tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
        veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
        commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
        velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
        occaecat cupidatat non proident, sunt in culpa qui officia deserunt
        mollit anim id est laborum.
      </p>
    {{/ic-tab-panel}}

    {{#ic-tab-panel}}
      <h2>Noodles</h2>
      <p>
        Tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
        veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
        commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
        velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
        occaecat cupidatat non proident, sunt in culpa qui officia deserunt
        mollit anim id est laborum.
      </p>
    {{/ic-tab-panel}}

    {{#ic-tab-panel}}
      <h2>Toast</h2>
      <p>
        Veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
        commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
        velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
        occaecat cupidatat non proident, sunt in culpa qui officia deserunt
        mollit anim id est laborum.
        Tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim.
      </p>
    {{/ic-tab-panel}}
  {{/ic-tabs}}

  App.ApplicationController = Ember.Controller.extend({
    queryParams: ['country', 'food'],
    country: 0,
    food: 'hamburger'
  });

Use with Ember CLI

I've been trying to get ic-tabs into my Ember CLI project without success. I tried importing it in the Brocfile a la the ic-ajax example, but I kept getting errors.

Has anybody used ic-tabs with Ember CLI?

instructure / ic-tabs Goto Github PK

ic-tabs's People

Contributors

Stargazers

Watchers

Forkers

ic-tabs's Issues

figure out why travis-ci isn't running any tests

Ember 1.8.0 compatibility

Error using ember v1.9.1

ic-styled

test/fix support for dynamic tabs

Developing

Passing Index to #ic-tab does not initialize properly

Use with Ember CLI

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent