instantiations / pigpio-vast Goto Github PK

In many places of the RaspberryHardware core refers to the word GPIO instead of Pigpiod. Examples is the classes RaspberryGpioDaemonInterface and RaspberryGpioInterface. In that case the "Gpio" is not really GPIO as the phisical pin (hardware) but the LIBRARY. Therefore, that must be Pigpio.

There are probably other places than these 2 class names where it calls "Gpio" instead of "Pigpiod". We should try to rename as much as we can see.

Right now, GPIOPortMCP23017 works with a device. The API of that device is basically a subset of I2CDeviceGPIOMCP23017. I believe that subset of functionality / API should eventually be moved up in the hierarchy (to I2cDevice or GpioBusDevice). That way, GPIOPortMCP23017 could be renamed to GPIOPort and depending on which device you pass, it would use either the GPIOs of MCP23017 or the native ones.

At this point, it would also be interesting to think if those GpioBusDevice and similar GPIO* classes should be renamed to Pigpio*.

At least some basic things like formatting on all the apps...

Something like pullUpAllPins and pullDownAllPins that do output: 0 or output: 16rFFFF

The Carrillon project has a nice I2CDeviceGPIOMCP23017 as well as reifieed the GPIOPort.
We should move all that from Carrillon to this repo.

We should explain better that in VAST, we can only use RaspberryGpioDaemonInterface so far and that RaspberryGpioInterface crashes the VM. We should put that as class comments or even rename RaspberryGpioInterface to RaspberryGpioInterfaceBROKEN or move it to a separate subclass or something. In addition, we can implement RaspberryGpioInterface class >> raspberryGpioStart doing a self error: 'not supported... use daemon instead....

OneWireDS18B20ThermometerDevice>temperature fails to close the file after reading it. See new code below.

temperature
"Answer the current temperature value of this device. It is possible the device may not have reported a correct list
of data, so return 999 as a placeholder"
| file data pos tStr |

file := CfsReadFileStream open: devFilePath.
file isCfsError ifFalse: [
	data := file contents.
            file close.                                    "This is the new line."
	((data indexOfSubCollection: 'YES') > 0) ifTrue: [
		pos := data indexOfSubCollection: 't='.
		(pos > 0) ifTrue: [
			tStr := data copyFrom: pos + 2 to: data size.
			^tStr asNumber / 1000.0.
		].
	].
].
^999.