Coder Social home page Coder Social logo

Comments (2)

amyreese avatar amyreese commented on June 2, 2024

Seems related to #375

from fixit.

llllvvuu avatar llllvvuu commented on June 2, 2024

EDIT: Fix submitted: #391

This is due to Instagram/LibCST#389 .

Simplified repro:

    VALID = [
        ...
        Valid('"True" == "True"'),  # passes
        Valid('"True" != "False".lower()'),  # fails
        Valid('lower = lambda x: x.lower()\n"True" != lower("False")'),  # passes
        Valid('"True" != lower("False")'),  # passes
    ]
dap> right_comp
...
  func: Attribute(\n    value=SimpleString(\n        value='"False"',\n        lpar=[],\n        rpar=[],\n    ),\n    attr=Name(\n        value='lower',\n        lpar=[]
...
dap> self.metadata[QualifiedNameProvider][right_comp]()
{QualifiedName(name='...ILTIN: 2>)}
  4354005056: QualifiedName(name='builtins.None', source=<QualifiedNameSource.BUILTIN: 2>)
  function variables:
  len(): 1
  special variables:
dap>

I think it should either return {String.lower} or {}, not {None}?

That being said, I think the lint issue could be fixed by just not using QualifiedNameProvider. You can just look at the node directly.

from fixit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.