inikulin / dmn Goto Github PK

There's this ugly warning when installing dmn:

npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

I've attempted to update dependencies to their latest version, but they seem to contain some breaking changes as tests fail left and right afterwards.

I think it's time for a rewrite, I find the current code structure quite confusing and would prefer a rewrite that only retains the functionality of cleaning node_modules (don't need the others). Ideas:

• Single-file executable script
• Use a glob implementation that uses uv_fs_scandir under the hood for performance, e.g. withFileTypes of fs.readdir
• Multiple classes for cleaning files, e.g. safe, unsafe
• Recursive support with some logic to never remove whole modules
• Maybe statically analyze modules on which files it loads, so we can exclude them

Seems like there is a pretty serious memory leak in this module, to reproduce:

npx create-react-app memleak
cd memleak
npx dmn clean -f

This will result in

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

By the way, I'm kind of tempted to rewrite the module, probably under a new name and with the only functionality of cleaning node_modules 😉

@inikulin Any interest in adding more collaborators (or giving me admin access so I can do it) on this repository? @silverwind is doing some good work and seems to care, so they'd be a good candidate.

Line endings are huge PITA for people who use different OS's for development (like I do). \n is not recognized by Windows in some editors, meanwhille \r\n ends up with extra ^M character in *nix systems. Currently dmn enforces \r\n in generated files (see: inikulin/ineed#3). We need to take smarter approach. Use the following strategy: If we already have .npmignore use it's line endings, otherwise use line endings of the OS in which dmn was invoked.