inhies / go-bytesize

Package bytesize provides functionality for measuring and displaying byte sizes.

ByteSize

Bytesize is a package for working with measurements of bytes. Using this package allows you to easily add 100KB to 4928MB and get a nicely formatted string representation of the result.

Usage

Check the built in documentation for examples using the godoc link above or by running godoc locally.

go-bytesize's Issues

Missing support of bytesize with decimals

Hi @inhies,

First of all many thanks for your work.

When you a have big unit like MB, GB, etc you coul want to parse some bytesize like:

• 440.8MB
• 220.45TB

But here :

go-bytesize/bytesize.go

Line 110 in 5990f52

if !unicode.IsDigit(r) {

You only match digit.

This can be easly fixed unsing something like this:

	if !unicode.IsDigit(r) && r != '.'

Thanks !

Support differences of -ga an -bi bytes (Gigabyte/GB, Gibibyte/GiB)

I've noticed that in this repository, gigabytes are defined as 1073741824 bytes. Most people think this is the case, however as defined by SI this should be exactly 1e+9 bytes. This subtle difference can be very confusing.

The problem with this change would be backwards compatibility, as people will be expecting GB to be 1073741824 bytes and KB to be 1024, etc. I'm not sure how to tackle this yet. For example, a new package could be created or a new Format function could be created (name to be determined, something like FormatSI?) that keeps this in mind.

I'll take a look at the source code soon to see whether it is any trivial to create a PR for this by myself.

It is also the question whether people really need this technically correct implementation. The fact that there has been no such issue for however long this package exists might say something about the willingness of people to use SI correct units in programming.

Add parsing power-of-two of Gi, Mi and so on

Example: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-memory

Great library

Thanks for making this!
:)

uint64 fork

fyi I have forked this lib and used a uint64 instead of a float64 for storing the byte number.
https://github.com/MalteJ/go-bytesize