ingydotnet / module-manifest-skip-pm Goto Github PK

Module::Manifest::Skip uses Moo but it isn't specified as a requirement in Makefile.PL or META.yml. Installation will fail if Moo isn't already installed.

xo patch

See robrwo/Dist-Zilla-Plugin-Generate-ManifestSkip#1 (comment)

The problem seems to be caused by this line in Module::Manifest::Skip (@ingy FYI)

77: elsif ($path =~ s!(\S.?)[\/]?\blib\b.!$1! and -e "$path/share") {

If Module::Manifest::Skip is installed in a path which has a "lib" component, and if there's a "share" directory next to it, then this share directory will be used. This is often the wrong directory. For example, in my installations the Module::Manifest::Skip path looks like /usr/perl5.24.1p/lib/site_perl/5.24.1/Module/Manifest/Skip.pm. So if there's a /usr/perl5.24.1p/share directory (which is created by some CPAN distributions, e.g. spamassassin), then things fail.

Tests for a module that uses this one fail because it does not explicitly require File::ShareDir.

As per subject. Sample fail report: http://www.cpantesters.org/cpan/report/1e7e65ee-7f85-11ea-ae1b-d44413b2f638

Pinging @haarg

See https://rt.cpan.org/Ticket/Display.html?id=141565. It checks filenames against MANIFEST.SKIP, and that rule causes it to think that the "t" directory is missing.