indigounited / js-err-code Goto Github PK

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Bunch of ipfs related repos are in the process of adopting typescript using jsdoc syntax and I would like to provide patch to do the same here so that typed projects using this could get get a better inference and code intellisence.

If you pass a string as the first argument, this module will new up an Error for us, which is convenient and all but means the stack trace for the error starts in the err-code module and not at the throw site.

This leads to developer confusion as there are irrelevant lines in the stack trace, and also leaks internal implementation details of the calling code (e.g. that err-code is used) which seems like an anti-pattern.

Accepting a string as the first argument should be deprecated and removed in a future release in favour of passing in Error objects.

What do you think?

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Hi there!
Being aware of #19, have you considered using Error.captureStackTrace to provide String support without the additional stack entry ?
Cheers,

This module uses a custom eslint config that requires an old version of eslint.

Attempts to upgrade eslint fail CI with:

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer @satazor/[email protected] wants eslint@^3.0.0
npm ERR! peerinvalid Peer [email protected] wants eslint@^2.0.0 || ^3.0.0

Any objections to just switching to standard for linting?

cc @satazor

Version 14.2.0 of browserify just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As browserify is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Can we have a license file added to the repo?