indigo744 / modx-revo-simple-ace-code-editor Goto Github PK

The lines jump to the cursor position in column 1 when code is edited in non-fullscreen mode.

After going fullscreen and back again (the short white blank in the anim-gif), everything works as expected.
The solution to switch to another style template does not work.

Currently, Ace doesn't render in the CMP that ContentBlocks (https://modmore.com/contentblocks/) offers.

Since it was made available to initialize on TVs, I was curious if we could get support for ContentBlocks.

Thanks!

Hello mate, I realise that the shortcut "Control + F" to open the Search box inside any chunk is opening the SimpleACE search box and the Chrome Search box at the same time, annoying behavior, did you see this too?

Hello mate, based on the 1.3.1 release, the icon on the top corner to make the code are full screen is missing.
Thanks mate.

When I set a resource to an empty template I get the following error:

Fatal error: Uncaught Error: Call to a member function getTemplateVarList() on null in xx\core\cache\includes\elements\modplugin\9.include.cache.php:385 Stack trace: #0 xx\core\model\modx\modscript.class.php(70): include() #1 xx\core\model\modx\modx.class.php(1608): modScript->process() #2 xx\manager\controllers\default\resource\resource.class.php(160): modX->invokeEvent('OnDocFormPreren...', Array) #3 xx\core\model\modx\modmanagercontroller.class.php(158): ResourceManagerController->firePreRenderEvents() #4 xx\core\model\modx\modmanagerresponse.class.php(74): modManagerController->render() #5 xx\core\model\modx\modmanagerrequest.class.php(183): modManagerResponse->outputContent(Array) #6 xx\core\model\modx\modmanagerrequest.class.php(131): modManagerRequest->prepareResponse() #7 D:\Stack\2_Htd in xx\core\cache\includes\elements\modplugin\9.include.cache.php on line 385

When I disable the plugin the error does not occur.

I am looking for the option to show the full screen toggle button.

Can it be done easily?

Hi there,

Awesome extra,

I am trying to integrate Emmet, as you list that I have to include the emmet alongside ace.js. After looking at the code (I am no expert in php) it looks like ace.js is being pulled in via a CDN, so where would you recommend I put the emment file?

Thanks for the updated ACE, the other one is a little ancient :)

Hi @Indigo744,

Thanks for the great extra. For one of my current projects, I am using a TV with a bit of code that is unique to each page. Currently I have a plugin running for the old ACE extra to syntax highlight the TV (that is set to a textarea).

I was wondering if there's any short way to have ACE syntax highlight based on a TV; i.e. how you can set chunks language in their description, but a similar way with TVs. I can post the plugin code that I have working with the old ACE extra if you would like.

This might be something totally unnecessary, so there's no worries to pass.

Thanks again!

Hello mate is me again, just to tell you there is a tiny problem with the search box on Fullscreen, it appear behind the manager buttons but it can be fixed easilly with a zindex:12 in the CSS file. See the picture.

Something else might be good is disabling the printing line that appear in the middle of the screen, it's quite annoying don't you think?.

Cheers mate.

Hello mate, I tried to download and install the package from ModX repo but is not working, then tried manually but not working again, can you please check it, the package looks good.

Cheers!!!

After updating MODX I can't get the theme to stay as I select it. I changed theme in the properties after unlocking, then saving the properties.

I'm using MODX 2.7.

Edit/Update:
TinymceWrapper was hijacking the plugin.

Conclusion:
You can only use one or the other, both plugins will not work together because Simple Ace Code Editor gets overridden by TinymceWrapper (because it also uses Ace).

Drag and drop from the file tree is broken.

How to test it

• Set the cursor to a particular spot inside a Ace editor.
• Open the file tab on the right side.
• Try to drag and drop a file into an editor textarea on the right side.

Whats supposed to happen

• The full path and filename is inserted at the current cursor position.

What happens instead

• Cursor position is lost and the path is inserted at the end of the code. On top of this, the Ace layout is changing.

Environment

• MODx 2.6.5,
• SimeplAceEditor 1.5.1,
• Chrome Version 70.0.3538.110

Fully installed and enabled but missing almost everything the old Ace extra had. You mention a list of properties that can be enabled (Auto-complete, Emmet, whatever you think CTRL-D does) but the only 2 properties available are AcePath and AceTheme... and even AcePath is using an OLD version of ACE, what's the deal?

I was excited to finally get an updated ACE with support for 4+ year old CSS properties cough Flex cough but this extra really under delivered.

Am I missing something obvious? Did I miss a checkbox somewhere? Please help me understand why this exists.

Hi,

Thanks for the great extra.

I have defined a property set and change the theme from new property set but it is not reflected. If I change it the from default, it works.

Is it possible to save the editor properties that you open with ctrl + Q. I can change these properties like wrapping or font-size, but each time you open the editor, you have to manually change them again.

I have some interesting discrepancies in the highlighting in MODX vs the Ace Editor highlight demo.

For instance, using the flex property for CSS: justify-content: center; in MODX it does not syntax highlight for justify-content, although in the Ace Editor demo seen here: (https://ace.c9.io/build/kitchen-sink.html) it highlights perfectly.

Could this be something to do with the custom MODX highlighting in modx_highlight_rules.js? It happens with the old Ace extra as well, and it seems the only similarities are that file pulled from that project.

Hello,

I'm trying to locate the setting for the theme in your Ace plugin for modx.

Where is it?

Hi,

When you select an "empty" template, it throws a fatal php error.

Call to a member function getTemplateVarList() on a non-object in ... modplugin/17.include.cache.php on line 385

The line is
$templateVarList = $modx->getObject('modTemplate', $templateId)->getTemplateVarList();

I had to uninstall the plugin to add a sitemap resource.