Coder Social home page Coder Social logo

Comments (3)

Snowknight26 avatar Snowknight26 commented on May 25, 2024

Couple notes:

There are a few workarounds:

  • You can enter fullscreen by double clicking the video
  • Resize the browser viewport such that its aspect ratio is wider than the aspect ratio of the video, allowing you to access the controls

Aside from that, it's not really possible to style native browser video controls, so the only solution that I can think of would be to introduce a custom set of controls in lieu of browser controls such that they can be styled properly and/or be in the DOM in the correct position to apply some kind of fix.

from immich.

Thinkscape avatar Thinkscape commented on May 25, 2024
  • You can enter fullscreen by double clicking the video

Users don't always want native full screen, and it won't work on mobile.

  • Resize the browser viewport such that its aspect ratio is wider than the aspect ratio of the video, allowing you to access the controls

This is a horrible suggestion... reminds me of late S.Jobs "You're holding it wrong".
Also won't fly with mobile devices where there is no window to drag around.
Also are users expected to drag around the window changing it constantly depending on aspect ratio of different assets?

Aside from that, it's not really possible to style native browser video controls, so the only solution that I can think of would be to introduce a custom set of controls in lieu of browser controls such that they can be styled properly and/or be in the DOM in the correct position to apply some kind of fix.

We should start using proper customisable video player, like video.js, Shaka etc.
Other than that, we could modify the CSS so that the carousel controls don't overlap (assume certain video controls height).

This bug also prevents users accessing the ❤️ and comment section on photos!

image

from immich.

Thinkscape avatar Thinkscape commented on May 25, 2024

Works great now. Thanks!

from immich.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.