imanghafoori1 / eloquent-relativity Goto Github PK

laravel/framework#33025

Hi, great package!

Is there any chance to make this package trait free?

hi Mr. Ghafouri

i install this package in my project , but does not work Because i use l5-repository package

when

php artisan serve

get error when i use DynamicRelations in PostRepository :

Call to undefined method Prettus\Repository\Eloquent\BaseRepository::__call()

get error when i use DynamicRelations in BaseRepository:

Cannot access parent:: when current class scope has no parent

Is it possible to guide me about this? (tnx)

Hi, this is a simple suggestion, but why the methods are not following the standard PSR-1?
Method names MUST be declared in camelCase.

I understand that there are already methods called like morphMany, so this is, i guess, the reason why you choose to use morph_many, but wouldn't fell more natural and readable to use methods like
attachMorphMany or addMorphMany or dynamicMorphMany?

Hi, currently to map all relationships added i'm using this:

use Illuminate\Support\Collection;
use ReflectionClass;
use App\Models\Foo;

$model = Foo::class;
$class = new ReflectionClass($model);
$property = $class->getProperty('dynamicRelations');
$property->setAccessible(true);
$methods = array_keys($property->getValue('dynamicRelations'));

Is there a way to do this without reflection?
Maybe adding an interface and a public method getDynamicRelations()

Thanks

Thank you for this, and your other packages. They are quite helpful for decoupling. Will this be updated to L8? It's basic dependency updates, really I'm curious if this package is maintained anymore.

Thanks for the great work. Much appreciated.

What should be the best approach to attach relationships based on a condition of the given entity if the class is the same?

For example:

• attach relationship detail to all entities Book that have an attribute type=foo
• attach relationship friends to entity BasicEntity that have table value cats

I'm asking this because i have one single Model that in each instance may have different table values because these models are defined in the database and there is only one class.

Can i make a PR about this or should i simple create an addon/extension?