No writable volume found after workflow failure & subsequent workflow reload about imagr

[grahamgilbert]

Pull the latest code, this should solve it.

[erikng]

First test worked but trying it additionally caused Imagr not to remount the volume. Odd.

Sent from my iPhone

On May 13, 2015, at 8:29 AM, Graham Gilbert [email protected] wrote:

Pull the latest code, this should solve it.

—
Reply to this email directly or view it on GitHub.

[grahamgilbert]

Ok, this is my last try. I can't think of any other way to solve this. Every volume that's known is checked and mounted if needed.

[erikng]

Latest commit now behaves similar to your commit from a few hours ago.
:/

[grahamgilbert]

Definitely fixed, actually tested it this time rather than guessing.

[erikng]

May I ask how you are testing this? I pulled the latest version and it fails to pull the image, then still gives the warning without remounting the volume.

[grahamgilbert]

Make nbi BUILD=Testing

Run an image workflow that has a url that will 404, run said workflow. Open disk utility and confirm that volume is mounted.

[erikng]

I'm going to make a new nbi instead of make update to just to be sure.

[erikng]

Perhaps someone else can validate this. It's still not working for me.

My test workflow is only an AutoDMG.

[clburlison]

@erikng The issue you are describing is resolved on my side using the latest commit.

https://www.dropbox.com/s/rffzx1yz3711h5u/imagr_image_error.mov?dl=0

[erikng]

Talking in IRC, my particular volume is CoreStorage. The last Imagr deployment I ran had a workflow script to convert it to CoreStorage.

Perhaps this is the difference.

[vmiller]

@erikng That seems to be it! Dropped into Terminal in my test VM and converted the volume to Core Storage and now I see "No writable volumes found" after reloading workflows.

[grahamgilbert]

This looks like an issue with diskutil itself. If someone can help find the correct command, this will easily be fixed. On a R/W disk image that has been converted to CoreStorage:

$ diskutil mountDisk disk3
> Volume(s) mounted successfully

Which is a lie!

[grahamgilbert]

Who just pushed a fix for this? That's right, I did! Long story short, diskutil was always identifying it as a whole disk, regardless of whether it is or not (which it's not). We're only ever dealing with volumes at the moment and not whole disks, so I took out the check that determines whether we need diskutil mount or diskutil mountDisk.

Test and confirm fixed for you guys.

[erikng]

Working. PR now up as well.