Coder Social home page Coder Social logo

Please look at my fork about imagr HOT 4 CLOSED

gregneagle avatar gregneagle commented on July 18, 2024
Please look at my fork

from imagr.

Comments (4)

grahamgilbert avatar grahamgilbert commented on July 18, 2024

I like the general idea. The layout is a bit hard to read at the top - maybe a panel or something so the labels are easier to read? Also, it beach balls when a new volume is mounted. I don't think this will be much of a problem in practise as most will be imaging internal volumes, but it would be good to get it on it's own thread with some feedback on what it's doing.

from imagr.

gregneagle avatar gregneagle commented on July 18, 2024

The NSWorkspace notifications actually have the info on volumes being mounted and unmounted; we don't really need to go through the lengthy task of rescanning for volumes, but I did it for this initial stab because it was easy.

If we don't scan, but just add or remove or rename the one volume it should be pretty fast.

Or, yes, we could rescan.

I still think (as I mentioned in a previous issue) that the code that builds the list of available volumes could be optimized as well -- it's dreadfully slow.

As for the cosmetic issues, those are easily addressed in many possible ways.

from imagr.

grahamgilbert avatar grahamgilbert commented on July 18, 2024

Make a pull request. These issues can be worked through once it's merged in. I have other GUI tweaks to make so it will be easier to start those after this is merged than try to smush them together.

from imagr.

grahamgilbert avatar grahamgilbert commented on July 18, 2024

Closing as this was merged in #71

from imagr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.