Coder Social home page Coder Social logo

Comments (10)

grahamgilbert avatar grahamgilbert commented on July 18, 2024

This is largely by design. The only improvement I can think of would be to disable the quit item so the app can't be quit without restarting. What failures would a retry solve? The only ones I can think of are:

  • 404 for image or package
  • pre boot script or package install failure
  • restore failure (which admittedly might be a temporary network problem, but I think that's an edge case).

from imagr.

natewalck avatar natewalck commented on July 18, 2024

Imagr doesn't allow you to continue unless there is already a partition present, so that averts local disk issues, correct?

@grahamgilbert, I assume your thinking is that if the workflow fails, then it was not crafted well? As in, if a workflow fails, you shouldn't fiddle with things locally until it works, you should fix the workflow.

from imagr.

erikng avatar erikng commented on July 18, 2024

By "retry" I mean allowing someone to pick a workflow again, not retry from the current location.

When DeployStudio fails, you are allowed to quit or continue. Continue takes you back to the workflow area to reselect.

from imagr.

natewalck avatar natewalck commented on July 18, 2024

I think the question is...if the workflow fails once, when would running it again have a different outcome?

from imagr.

erikng avatar erikng commented on July 18, 2024

When it's been fixed and I "refresh workflows" with the new button.

from imagr.

natewalck avatar natewalck commented on July 18, 2024

Ah, I see. So instead of bailing the whole app, bail back to the selector.

from imagr.

erikng avatar erikng commented on July 18, 2024

Exactly. :)

from imagr.

grahamgilbert avatar grahamgilbert commented on July 18, 2024

At the moment, there's one kind of failure - one that results in the error modal. It seems like we need two kinds of failure. Hard failures where nothing can continue (no config plist etc) and those that can dump you back to the select workflow screen.

from imagr.

gmarnin avatar gmarnin commented on July 18, 2024

I ran into this today. I had a mistake in my image_config.plist which I fixed but was unable to click on refresh workflows because it was grey out.

from imagr.

grahamgilbert avatar grahamgilbert commented on July 18, 2024

Fixed in 55ba856

from imagr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.