Comments (10)
This is largely by design. The only improvement I can think of would be to disable the quit item so the app can't be quit without restarting. What failures would a retry solve? The only ones I can think of are:
- 404 for image or package
- pre boot script or package install failure
- restore failure (which admittedly might be a temporary network problem, but I think that's an edge case).
from imagr.
Imagr doesn't allow you to continue unless there is already a partition present, so that averts local disk issues, correct?
@grahamgilbert, I assume your thinking is that if the workflow fails, then it was not crafted well? As in, if a workflow fails, you shouldn't fiddle with things locally until it works, you should fix the workflow.
from imagr.
By "retry" I mean allowing someone to pick a workflow again, not retry from the current location.
When DeployStudio fails, you are allowed to quit or continue. Continue takes you back to the workflow area to reselect.
from imagr.
I think the question is...if the workflow fails once, when would running it again have a different outcome?
from imagr.
When it's been fixed and I "refresh workflows" with the new button.
from imagr.
Ah, I see. So instead of bailing the whole app, bail back to the selector.
from imagr.
Exactly. :)
from imagr.
At the moment, there's one kind of failure - one that results in the error modal. It seems like we need two kinds of failure. Hard failures where nothing can continue (no config plist etc) and those that can dump you back to the select workflow screen.
from imagr.
I ran into this today. I had a mistake in my image_config.plist which I fixed but was unable to click on refresh workflows because it was grey out.
from imagr.
Fixed in 55ba856
from imagr.
Related Issues (20)
- imagr open behind select language pane in macOS Sierra HOT 3
- Imagr crashes if reporting server unavailable HOT 2
- Imagr crashes if timeapi.org returns unexpected data HOT 1
- Description text box for the workflows is not scrollable HOT 1
- Imagr logs a crash if a volume is unmounted HOT 2
- Setting time with http fails to respect timezone HOT 4
- Bug: first-boot items are not installed in order in macOS High Sierra
- validateplist doesn't append query string to background_image check
- Packages/DMGs with spaces will fail if using gurl HOT 2
- Feature request: Prevent Mac from sleeping while Imagr app is running a workflow HOT 1
- first-boot infinite loop if exit code non-zero HOT 7
- After APFS to HFS Conversion via script will casue Imagr to hang HOT 9
- Does not work with macOS 10.13.4 Installer HOT 4
- 10.11 NBI workflow start crash HOT 1
- Workflow doesn't recognize volume format change HOT 4
- Auto key of computer_name component ignored when part of included workflow HOT 2
- com.apple.osinstall error -3 on OS X 10.13.4 if workflow writes to formatted target before startosinstall HOT 2
- first_boot LaunchDaemon does not get created when startosinstall is called via included_workflow HOT 1
- Imagr (High Sierra) preventing reboot during install workflow HOT 1
- first-boot fails to start after Mojave install HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imagr.