Coder Social home page Coder Social logo

Comments (6)

ripytide avatar ripytide commented on July 26, 2024

If that order was unexpected why not just fix that probably accidental mistake?

from imageproc.

cospectrum avatar cospectrum commented on July 26, 2024

This is a common mistake, everyone will make it at some point. We can fix this once and for all.

from imageproc.

ripytide avatar ripytide commented on July 26, 2024

Isn't it still useful to have a convention of argument order though? It makes reading the source code easier.

from imageproc.

cospectrum avatar cospectrum commented on July 26, 2024

But you don't need a biased standard output for that, name a variable.
And there are situations when there is no actual or expected result, you just want to compare.

from imageproc.

ripytide avatar ripytide commented on July 26, 2024

Fair enough, I would still suggest fixing the wrongly ordered assert though for consistencies sake.

from imageproc.

theotherphil avatar theotherphil commented on July 26, 2024

I prefer to have a consistent ordering of actual vs expected values in test definitions and error messages. I’ll leave this issue open until I’ve checked for other tests with back to front arguments in their assertions.

from imageproc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.