Coder Social home page Coder Social logo

Comments (3)

ripytide avatar ripytide commented on July 26, 2024

Continuing the discussion from #647:

All of the draw_x functions accept inputs that may be extend outside the image and then only draw the points that are within the image bounds. This is a bit odd if you think of the image as a finite canvas but makes more sense for the original use case for several of these functions which was to annotate photos/video frames with areas of interest identified using these images.
I’d rather keep the consistency between these functions so won’t merge this PR.

May I ask what the use-cases are for annotating images in areas outside of the image in photo/video frames as that does seem a bit odd to me.

from imageproc.

ripytide avatar ripytide commented on July 26, 2024

Since the crop() function needs an unsigned rectangle input it might be worth creating another Rect and possibly naming them differently so functions can choose which Rect type they want to take as parameters.

Something like:

struct RectI {
x: i32,
...
}

struct RectU {
x: u32,
...
}

from imageproc.

ripytide avatar ripytide commented on July 26, 2024

Or maybe simply asking upstream to make their Rect type generic that way we can have Rect<u32> and Rect<i32>.

from imageproc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.