Comments (3)
Continuing the discussion from #647:
All of the draw_x functions accept inputs that may be extend outside the image and then only draw the points that are within the image bounds. This is a bit odd if you think of the image as a finite canvas but makes more sense for the original use case for several of these functions which was to annotate photos/video frames with areas of interest identified using these images.
Iβd rather keep the consistency between these functions so wonβt merge this PR.
May I ask what the use-cases are for annotating images in areas outside of the image in photo/video frames as that does seem a bit odd to me.
from imageproc.
Since the crop()
function needs an unsigned rectangle input it might be worth creating another Rect
and possibly naming them differently so functions can choose which Rect
type they want to take as parameters.
Something like:
struct RectI {
x: i32,
...
}
struct RectU {
x: u32,
...
}
from imageproc.
Or maybe simply asking upstream to make their Rect
type generic that way we can have Rect<u32>
and Rect<i32>
.
from imageproc.
Related Issues (20)
- Try using doc_auto_cfg to automate addition of docrs attributes
- Rename `imageproc::map::map_colors()` to `map_pixels()` HOT 2
- Another doc-macro for parallel variations of functions?
- `Rect` refactors HOT 2
- Add filter benchmarks for kernels larger than 3x3
- Add hardcoded filter3x3 function to benchmark current generic filter function against HOT 19
- `Laplacian` from `master` is wrong HOT 4
- Check for any functions missing tests
- Use `Kernel` by `ref` HOT 2
- Document release process
- Agree a sensible API for filtering so we can reduce the risk of frequent breaking changes to signatures HOT 3
- Fix filter performance vs simple hardcoded implementation
- Add Tags for all previous releases where possible HOT 2
- Decide module layout for new imageops functions HOT 1
- how encode drawed image to [u8] ? HOT 6
- Rounded corners on rectangles and images HOT 4
- Projection matrix for rotation is weird
- Add `#[must_use]` to all non-mut image processing functions
- Broken links in docs.rs documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imageproc.