idle-pb / squint Goto Github PK

Please, add the following topics to the repository (via the Manage topics option, below the repository headline):

purebasic algorithm trie

This will improve the repo's visibility on GitHub, as well as making PureBasic projects more visibile in general.

I've also added these topics to my fork:

https://github.com/tajmone/SQUINT

• Fix discrepancies in MIT copyright notices of LICENSE file and PB sources.
• In squint/Squint.pbi, fix ; MIT License to ; License MIT.

In the LICENSE file, the MIT copyright notice states:

Copyright (c) 2020 idle-PB

whereas in the squint/Squint.pbi the MIT copyright notice states:

; License MIT
; Copyright (c) 2020 Andrew Ferguson

The main license of the repository and the licenses inside source files should match — also, the fact that "idle-PB" and "Andrew Ferguson" are the same person might not be obvious.

Also, it should be MIT License, not License MIT (it's the proper name of the license, you should preserve it as it is).

Note that in the header comments of squint/Squint.pbi you also mention:

; Copyright (c) 2020 Andrew Ferguson aka Idle

But again, legally speaking "Idle" (the PB account) doesn't match "idle-PB" (the GitHub user account), so the problem is that end users are being presented with two different MIT licenses, with different copyright claims, which makes it somewhat problematic to properly fulfil the license terms.

My advise is to merge the various user accounts and your real name into a single copyright notice that is consistent wherever is mentioned:

Copyright (c) 2020 Andrew Ferguson (@idle-PB) aka Idle

Furthermore, adding your full name to your GitHub profile might dispel any legal doubts about your paternity of the code.

As a final note, although you don't need to add the full MIT License text to every PB source (having it in the main module suffices), it would be a good idea to at least add a one-liner about the copyright and license status, like:

; Copyright (c) 2020 Andrew Ferguson (aka "Idle"), MIT License.

otherwise it's not implicit that the license of the Squint.pbi also covers the other files (in case they start to circulate outside this repository, without the LICENSE file).

Could you please enable the project's Wiki, for public editing?

It could be a useful tool to add articles on tries, comments on the PB implementation, ideas, etc., or even just links to external resources and additional readings.